Remove Bouncy Castle from X.509 key identifier parsing - #647
Open
araiprof wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
ws-security-common declares the Bouncy Castle artifacts as optional, but these key-identifier paths directly linked BC classes. That meant core certificate handling could fail when those optional artifacts were absent. X509Certificate already exposes the encoded extension values, so the small amount of required DER structure can be decoded without selecting or registering a cryptographic provider.
This does not change cryptographic primitive selection and does not make Cryptacular optional. OpenSAML/SAML users still retain their existing dependency path. The public BouncyCastleUtils name and methods are retained for source and binary compatibility.
Malformed encodings are now rejected more strictly; X.509 extensions are required to use DER.
Verification