Merged
Conversation
Removes gremlin-annotations from GLV exclusions as it is needed for gremlin-groovy, which is needed for gremlin-server Adds gremlin-coverage to GLV exclusions as it depends on gremlin-console and neo4j-gremlin which are already excluded.
Contributor
|
doh, I'd missed the VOTE +1 |
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was noticed during the 3.8.1 release process that GLV github actions were failing due to missing Java modules. The GLV exclusions haven't been quite right since they were refactored a few months ago, which has only been hidden by the actions pulling stale SNAPSHOT's from maven central instead of using a locally installed cache.
Removes gremlin-annotations from GLV exclusions as it is needed for gremlin-groovy, which is needed for gremlin-server
Adds gremlin-coverage to GLV exclusions as it depends on gremlin-console and neo4j-gremlin which are already excluded.
This PR is not intended to be merged until after the 3.8.1 release is complete.
VOTE +1