Repository navigation
Conversation
Require clean JVM diagnostics and the expected success marker while preserving loader and logging failures. Add runner regressions to native CI and align test imports and checkout credential handling. Generated-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The native-loader smoke test enables
-Xcheck:jni, but JVM JNI warnings can leave the process exit status at zero. The runner previously accepted that result.Capture each JVM run, reject JNI diagnostics and require the correct fixture or packaged-load success marker while preserving JVM and logging failures. Add focused runner regressions and run them in native CI. Also make native checkout credential handling consistent and clean up the packaging/licensing test imports.
Follow-up to #474.
Why are the changes needed?
A zero JVM exit status does not prove that the JNI loader smoke passed without diagnostics.
Does this PR introduce any user-facing change?
No runtime API change. Native CI now fails when loader checks emit JNI diagnostics or omit their success marker.
How was this patch tested?
Eight runner regressions, 33 packaging tests and 35 licensing tests passed. Diagnostic rejection is covered by fake-tool regressions; no real JNI misuse was induced. Real fixture and packaged-library loading passed on macOS ARM64 with JDK 21. Hosted cross-platform CI remains pending.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6)
This pull request and its description were written by OpenAI Codex.