Skip to content

[CONNECT] Reject JNI diagnostics in native loader validation - #903

Draft
dbtsai wants to merge 1 commit into
apache:masterfrom
dbtsai:codex/native-connect-loader-validation
Draft

dbtsai wants to merge 1 commit into
apache:masterfrom
dbtsai:codex/native-connect-loader-validation

Conversation

@dbtsai

@dbtsai dbtsai commented Nov 20, 2026

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

The native-loader smoke test enables -Xcheck:jni, but JVM JNI warnings can leave the process exit status at zero. The runner previously accepted that result.

Capture each JVM run, reject JNI diagnostics and require the correct fixture or packaged-load success marker while preserving JVM and logging failures. Add focused runner regressions and run them in native CI. Also make native checkout credential handling consistent and clean up the packaging/licensing test imports.

Follow-up to #474.

Why are the changes needed?

A zero JVM exit status does not prove that the JNI loader smoke passed without diagnostics.

Does this PR introduce any user-facing change?

No runtime API change. Native CI now fails when loader checks emit JNI diagnostics or omit their success marker.

How was this patch tested?

Eight runner regressions, 33 packaging tests and 35 licensing tests passed. Diagnostic rejection is covered by fake-tool regressions; no real JNI misuse was induced. Real fixture and packaged-library loading passed on macOS ARM64 with JDK 21. Hosted cross-platform CI remains pending.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: OpenAI Codex (GPT-6)

This pull request and its description were written by OpenAI Codex.

Require clean JVM diagnostics and the expected success marker while preserving loader and logging failures. Add runner regressions to native CI and align test imports and checkout credential handling.

Generated-by: OpenAI Codex

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant