Repository navigation
Conversation
Move the SigV4 request-signing body into the shared AWS core so internal STS operations can use the exact same implementation as the public request signer without adding a dependency on the SigV4 service crate.
Resolve a selected role profile through its source_profile graph, load a named or legacy SSO source through the configured SSO slot, and assume each role in order with the previous hop's credential. Validate missing sources, cycles, conflicting or unsupported credential_source, region, and grant fields before STS or SSO network I/O, and keep role-chain/SSO failures from selecting a later identity.
PsiACE
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #856.
A selected profile with
role_arnnow resolvessource_profilereferences to a static or SSO base, loads a named or legacy inline SSO source through the configured SSO slot, and assumes each role in order with the previous hop's credential.AWS_PROFILEand explicitwith_profile(...)both drive the graph.no_sso()prevents SSO from participating, and role-chain or SSO failures stop resolution instead of selecting a later identity.The graph is validated before SSO or STS network I/O: missing source profiles, cycles, both or unsupported
credential_source, a missing STS region, and invalid grants produce actionable errors. Static sources,duration_seconds, andexternal_idare supported;credential_source-only role profiles remain explicitly unsupported.To execute STS from the profile provider without a core-to-v4 dependency cycle or a second signing implementation, the SigV4 request body moved into
reqsign-aws-core's hidden signing module and the publicRequestSignerdelegates to it. Crate boundaries and public re-exports are unchanged.Validation uses synthetic profiles and mocked HTTP only, with no live cloud credentials:
cargo fmt --all -- --checkcargo clippy -p reqsign-aws-core -p reqsign-aws-v4 --all-targets --all-features -- -D warningscargo test -p reqsign-aws-core -p reqsign-aws-v4cargo check -p reqsign-aws-core -p reqsign-aws-v4 --target wasm32-unknown-unknowncargo check -p reqsign --features fullCoverage includes explicit and
AWS_PROFILEselection, named SSO sources, multi-hop order and per-hop credentials, static sources,no_sso(), pre-I/O missing-source/cycle/conflict/region/invalid-ARN failures, and signer consumption of the final assumed credential.