Repository navigation
build(deps): update rsa requirement from 0.9.2 to 0.10.0 - #941
dependabot[bot] wants to merge 9 commits into
Conversation
Updates the requirements on [rsa](https://github.com/RustCrypto/RSA) to permit the latest version. - [Changelog](https://github.com/RustCrypto/RSA/blob/v0.9.10/CHANGELOG.md) - [Commits](RustCrypto/RSA@v0.9.2...v0.9.10) --- updated-dependencies: - dependency-name: rsa dependency-version: 0.9.10 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
This bump is the only path to RUSTSEC-2023-0071 (Marvin, GHSA-c38w-74pg-36hr) for downstream users of reqsign: rsa 0.10.0 (2026-11-08) is the first release with constant-time arithmetic (crypto-bigint), and RustSec now lists >=0.10.0 as patched. The CI failures here look like the rsa 0.10 API change (BigUint → BoxedUint and the PKCS#1 signing types) rather than anything in reqsign's logic, so a port of reqsign-core, reqsign-google and reqsign-azure-storage is needed before this can merge. Is that on the roadmap? uv (astral-sh/uv) picks rsa up only through reqsign, so a reqsign release with rsa 0.10 would let it clear the advisory too. |
|
Tracking the rsa 0.10 upgrade separately. The public JWT helper accepts a key from rsa 0.9, and rsa 0.10 requires Rust 1.87. #944 now covers only the website and GitHub Actions updates. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
rsa 0.10 removes the sha2 feature and replaces the key and signature APIs. Keep only the byte-oriented encode_rs256_pem public helper and make the key-taking helper private. Azure forwards its existing certificate private-key PEM bytes to that entry point, so the service no longer depends on rsa directly. The upgrade requires Rust 1.87, so raise the workspace MSRV and update the documented minimum. Add synthetic certificate and key fixtures to cover Google/Azure JWT signing and Oracle PKCS#1/PKCS#8 parsing without real credentials. Provenance: dependency bump from #941 (cc16d14), applied on origin/main bc8de0b.
# Conflicts: # Cargo.toml
# Conflicts: # services/oracle/tests/private_key_formats.rs
Summary
Update
rsafrom 0.9 to 0.10 and port the RS256 signing paths. This is part of #437 and fixes thersa/sha2feature mismatch in the original dependency bump.reqsign_core::jwt::encode_rs256helper that accepted anrsakey. The byte-orientedencode_rs256_pementry point is unchanged.reqsign-googleandreqsign-oracleto thersa0.10 API. Oracle continues to accept unencrypted PKCS#1 and PKCS#8 PEM keys.encode_rs256_pem;reqsign-azure-storageno longer depends onrsadirectly.rsa0.10, and update the documented minimum.Caller migration
encode_rs256_pemkeeps its existing signature and behavior. Callers that used the removed key-taking helper should serialize their RSA private key as unencrypted PKCS#8 PEM and call the byte API:No
rsatype is re-exported, and no DER or wrapper entry point is added.Validation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --no-fail-fastcargo +nightly test --doc --all-features --workspacecargo +1.87.0 test -p reqsign-core --features jwt -p reqsign-oracle -p reqsign-google -p reqsign-azure-storagecargo +1.86 check -p reqsign-core --features jwtfails as expected becausersa0.10 requires Rust 1.87.wasm32-unknown-unknown: the core default check and the supported facade feature sets build.rsa0.9 and 0.10; the Azure client assertion is checked against a fixed expected JWT, and Oracle PKCS#1/PKCS#8 fixtures verify signatures.The existing Dependabot branch was advanced with a merge rather than rewritten. The
rsa0.10 upgrade is intended for the next release that permits breaking changes; this PR does not merge or release anything.