Skip to content

build(deps): update rsa requirement from 0.9.2 to 0.10.0 - #941

Open
dependabot[bot] wants to merge 9 commits into
mainfrom
dependabot/cargo/rsa-0.10.0
Open

dependabot[bot] wants to merge 9 commits into
mainfrom
dependabot/cargo/rsa-0.10.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Update rsa from 0.9 to 0.10 and port the RS256 signing paths. This is part of #437 and fixes the rsa/sha2 feature mismatch in the original dependency bump.

  • Remove the public reqsign_core::jwt::encode_rs256 helper that accepted an rsa key. The byte-oriented encode_rs256_pem entry point is unchanged.
  • Port reqsign-google and reqsign-oracle to the rsa 0.10 API. Oracle continues to accept unencrypted PKCS#1 and PKCS#8 PEM keys.
  • Azure client-certificate assertions now pass the certificate's existing PKCS#8 PEM bytes to encode_rs256_pem; reqsign-azure-storage no longer depends on rsa directly.
  • Raise the workspace MSRV from 1.86 to 1.87, required by rsa 0.10, and update the documented minimum.
  • Replace runtime key generation in tests with synthetic certificate/key fixtures.

Caller migration

encode_rs256_pem keeps its existing signature and behavior. Callers that used the removed key-taking helper should serialize their RSA private key as unencrypted PKCS#8 PEM and call the byte API:

let private_key_pem = private_key.to_pkcs8_pem(LineEnding::LF)?;
let jwt = reqsign_core::jwt::encode_rs256_pem(&header, &claims, private_key_pem.as_bytes())?;

No rsa type is re-exported, and no DER or wrapper entry point is added.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --no-fail-fast
  • cargo +nightly test --doc --all-features --workspace
  • cargo +1.87.0 test -p reqsign-core --features jwt -p reqsign-oracle -p reqsign-google -p reqsign-azure-storage
  • cargo +1.86 check -p reqsign-core --features jwt fails as expected because rsa 0.10 requires Rust 1.87.
  • wasm32-unknown-unknown: the core default check and the supported facade feature sets build.
  • RS256 output for a fixed synthetic key/input is byte-identical between rsa 0.9 and 0.10; the Azure client assertion is checked against a fixed expected JWT, and Oracle PKCS#1/PKCS#8 fixtures verify signatures.

The existing Dependabot branch was advanced with a merge rather than rewritten. The rsa 0.10 upgrade is intended for the next release that permits breaking changes; this PR does not merge or release anything.

Updates the requirements on [rsa](https://github.com/RustCrypto/RSA) to permit the latest version.
- [Changelog](https://github.com/RustCrypto/RSA/blob/v0.9.10/CHANGELOG.md)
- [Commits](RustCrypto/RSA@v0.9.2...v0.9.10)

---
updated-dependencies:
- dependency-name: rsa
  dependency-version: 0.9.10
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 16, 2026
@mr-zepol

Copy link
Copy Markdown

This bump is the only path to RUSTSEC-2023-0071 (Marvin, GHSA-c38w-74pg-36hr) for downstream users of reqsign: rsa 0.10.0 (2026-11-08) is the first release with constant-time arithmetic (crypto-bigint), and RustSec now lists >=0.10.0 as patched. The CI failures here look like the rsa 0.10 API change (BigUint → BoxedUint and the PKCS#1 signing types) rather than anything in reqsign's logic, so a port of reqsign-core, reqsign-google and reqsign-azure-storage is needed before this can merge. Is that on the roadmap? uv (astral-sh/uv) picks rsa up only through reqsign, so a reqsign release with rsa 0.10 would let it clear the advisory too.

@tisonkun

tisonkun commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Tracking the rsa 0.10 upgrade separately. The public JWT helper accepts a key from rsa 0.9, and rsa 0.10 requires Rust 1.87. #944 now covers only the website and GitHub Actions updates.

@tisonkun tisonkun closed this Nov 18, 2026
@dependabot @github

dependabot Bot commented on behalf of github Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/cargo/rsa-0.10.0 branch November 18, 2026 08:48
@tisonkun
tisonkun restored the dependabot/cargo/rsa-0.10.0 branch November 18, 2026 09:05
@tisonkun tisonkun reopened this Nov 18, 2026
rsa 0.10 removes the sha2 feature and replaces the key and signature
APIs. Keep only the byte-oriented encode_rs256_pem public helper and
make the key-taking helper private. Azure forwards its existing
certificate private-key PEM bytes to that entry point, so the service no
longer depends on rsa directly.

The upgrade requires Rust 1.87, so raise the workspace MSRV and update
the documented minimum. Add synthetic certificate and key fixtures to
cover Google/Azure JWT signing and Oracle PKCS#1/PKCS#8 parsing without
real credentials.

Provenance: dependency bump from #941 (cc16d14), applied on
origin/main bc8de0b.
# Conflicts:
#	services/oracle/tests/private_key_formats.rs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants