PHOENIX-7785 Avoid infinite loops & duplicate file processing for in progress directory#2395
Open
Himanshu-g81 wants to merge 3 commits intoapache:PHOENIX-7562-feature-newfrom
Open
PHOENIX-7785 Avoid infinite loops & duplicate file processing for in progress directory#2395Himanshu-g81 wants to merge 3 commits intoapache:PHOENIX-7562-feature-newfrom
Himanshu-g81 wants to merge 3 commits intoapache:PHOENIX-7562-feature-newfrom
Conversation
added 3 commits
March 26, 2026 19:16
tkhurana
reviewed
Apr 6, 2026
| */ | ||
| protected boolean markCompleted(final Path file) { | ||
| long startTime = EnvironmentEdgeManager.currentTimeMillis(); | ||
| long startTime = EnvironmentEdgeManager.currentTime(); |
Contributor
There was a problem hiding this comment.
I didn't understand the reason behind this change
Contributor
Author
There was a problem hiding this comment.
It's to use the same libraray across different classes in this module, so when current time is injected from test, it gets propogated to all the classes (instead of doing injecting for both the libraries in test code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.