PHOENIX-7779: move phoenix-queryserver to jUnit5.#189
Open
alexadunai wants to merge 4 commits intoapache:masterfrom
Open
PHOENIX-7779: move phoenix-queryserver to jUnit5.#189alexadunai wants to merge 4 commits intoapache:masterfrom
alexadunai wants to merge 4 commits intoapache:masterfrom
Conversation
…es need to be removed before merging.
… run 100% passed in 55.817s)
…junit5 (all test runs were successful)
…sh changes need to be removed before merging." This reverts commit dec732f.
richardantal
reviewed
Apr 9, 2026
Contributor
richardantal
left a comment
richardantal
left a comment
There was a problem hiding this comment.
This change looks quite good
Please do these small changes in ParameterizedPhoenixCanaryToolIT
| if(needsNewCluster()) { | ||
| setClientSideNamespaceProperties(); | ||
| setServerSideNamespaceProperties(); | ||
| if(needsNewCluster(isNamespaceEnabled)) { |
Contributor
There was a problem hiding this comment.
Can we use this.isNamespaceEnabled instead of passing parameters?
| "resultSinkOption" + this.resultSinkOption); | ||
| "isPositiveTestType" + isPositiveTestType + | ||
| "isNamespaceEnabled" + isNamespaceEnabled + | ||
| "resultSinkOption" + resultSinkOption); |
Contributor
There was a problem hiding this comment.
NIT
This is not related to your change, but it would be nice to add extra spaces to make this LOG line readable
| @Before | ||
| public void setup() throws Exception { | ||
| public void setup( | ||
| Boolean isPositiveTestType, Boolean isNamespaceEnabled, String resultSinkOption) throws Exception { |
Contributor
There was a problem hiding this comment.
Can we use this.isNamespaceEnabled, this.resultSinkOption and this.isPositiveTestType instead of passing parameters?
This applies to most of the places where we use isNamespaceEnabled, resultSinkOption and isPositiveTestType this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-task of PHOENIX-7779, updating jUnit to 5.10.2 for phoenix-queryserver all subcomponents.