Skip to content

include/debug.h: Use <nuttx/debug.h> in apps#3443

Open
PiyushPatle26 wants to merge 1 commit intoapache:masterfrom
PiyushPatle26:include/refactor-debug-h-location-apps
Open

include/debug.h: Use <nuttx/debug.h> in apps#3443
PiyushPatle26 wants to merge 1 commit intoapache:masterfrom
PiyushPatle26:include/refactor-debug-h-location-apps

Conversation

@PiyushPatle26
Copy link
Copy Markdown

@PiyushPatle26 PiyushPatle26 commented Apr 1, 2026

Note: Please adhere to Contributing Guidelines.

Summary

Update nuttx-apps to include <nuttx/debug.h> instead of <debug.h>.

This is the apps-side follow-up to the corresponding nuttx change that moves
the NuttX-specific debug header from include/debug.h to
include/nuttx/debug.h. Since debug.h is not a POSIX or standard C header,
using the namespaced path avoids collisions with external projects that may
also define a debug.h.

This change is mechanical: it updates existing include directives across
nuttx-apps to use the new header location.

Impact

  • Aligns nuttx-apps with the new canonical debug header location in nuttx.
  • Avoids continued dependency on the deprecated top-level <debug.h> path.
  • No intended functional behavior change.
  • No board-specific or hardware-specific impact.
  • Keeps nuttx-apps compatible with the corresponding nuttx header move.

Other PR for nuttx

Testing

Validation performed on Ubuntu Linux.

Host:

  • OS: Ubuntu Linux
  • Repository: nuttx-apps

Verification:

  • Verified there are no remaining source/header includes of <debug.h> in
    nuttx-apps after the update.
  • This change is a include-path update only; no runtime behavior is
    intended to change.

Target:

  • N/A for direct runtime testing in nuttx-apps alone

Related PR
Related Issue

jerpelea
jerpelea previously approved these changes Apr 1, 2026
@PiyushPatle26
Copy link
Copy Markdown
Author

@jerpelea @linguini1 the CI failure are for <nuttx/debug.h> doesn't exist, as CI takes the current nuttx master branch for testing, Can you guys have a look and give me an update?

@linguini1
Copy link
Copy Markdown
Contributor

Yes, this PR will have to wait for the other PR to be merged.

@PiyushPatle26 PiyushPatle26 force-pushed the include/refactor-debug-h-location-apps branch from 3aa8f88 to 4f92eb3 Compare April 7, 2026 11:13
@PiyushPatle26
Copy link
Copy Markdown
Author

@xiaoxiang781216 @jerpelea the PR got merged, now we can test the CI and if no errors , merge this one too

acassis
acassis previously approved these changes Apr 7, 2026
@PiyushPatle26 PiyushPatle26 force-pushed the include/refactor-debug-h-location-apps branch from 4f92eb3 to f342b60 Compare April 7, 2026 11:30
Replace app-side includes of <debug.h> with <nuttx/debug.h> to use the
header from the NuttX tree explicitly after the header move.

Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
@PiyushPatle26 PiyushPatle26 dismissed stale reviews from jerpelea and acassis via 29efdfc April 7, 2026 12:20
@PiyushPatle26 PiyushPatle26 force-pushed the include/refactor-debug-h-location-apps branch from f342b60 to 29efdfc Compare April 7, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants