Skip to content

NIFI-15711 Get raw commit author name if commit not tied to any GH user #11000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvillard31 merged 1 commit into from
Mar 13, 2026
Merged

NIFI-15711 Get raw commit author name if commit not tied to any GH user #11000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions ...e/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubRepositoryClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,18 +474,22 @@ private void throwPathOrBranchNotFound(final FileNotFoundException fileNotFoundE

private GitCommit toGitCommit(final GHCommit ghCommit) throws IOException {
GitCommit commit = commitCache.getIfPresent(ghCommit.getSHA1());
if (commit != null) {
return commit;
} else {

if (commit == null) {
final GHCommit.ShortInfo shortInfo = ghCommit.getCommitShortInfo();
final String author = ghCommit.getAuthor() != null
? ghCommit.getAuthor().getLogin()
: shortInfo.getAuthor().getName();

commit = new GitCommit(
ghCommit.getSHA1(),
ghCommit.getAuthor().getLogin(),
shortInfo.getMessage(),
Instant.ofEpochMilli(shortInfo.getCommitDate().getTime()));
ghCommit.getSHA1(),
author,
shortInfo.getMessage(),
Instant.ofEpochMilli(shortInfo.getCommitDate().getTime()));
commitCache.put(ghCommit.getSHA1(), commit);
return commit;
}

return commit;
}

private <T> T execute(final GHRequest<T> action) throws FlowRegistryException, IOException {
Expand Down
Loading