Skip to content

fix(examples): use Jakarta Jersey client, re-enable whiteboard tests - #3114

Merged
jbonofre merged 1 commit into
apache:mainfrom
holgerfriedrich:pr-rest-example-tests-3088
Nov 21, 2026
Merged

jbonofre merged 1 commit into
apache:mainfrom
holgerfriedrich:pr-rest-example-tests-3088

Conversation

@holgerfriedrich

Copy link
Copy Markdown
Contributor

This builds on #3088 (and contains it right now as well), and re-enables REST tests.

Jersey 3.x needs jakarta.ws.rs-api 3.1.0 and the Jakarta Jackson provider.

  • client-jersey, client-cxf: jakarta.ws.rs-api 3.1.0
  • client-jersey: jackson-jakarta-rs-json-provider; use JerseyClientBuilder, as the ServiceLoader lookup does not work in OSGi
  • client-jersey feature: install the jackson-jakarta-rs bundles
  • RestExampleTest: enable whiteboard tests (HTTP and Jersey clients), keep blueprint/SCR ignored (no CXF 4 Karaf features, see Upgrade to CXF 4.x #2461)

Opening it as a draft, it will need a rebase once #3088 is merged.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Test Results

1 112 files   - 4  1 112 suites   - 4   1h 26m 56s ⏱️ + 10m 12s
1 367 tests +1  1 236 ✅ +1  131 💤 ±0  0 ❌ ±0 
5 468 runs  +4  4 942 ✅ +4  526 💤 ±0  0 ❌ ±0 

Results for commit 2c04c6d. ± Comparison against base commit a89efac.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
org.apache.karaf.itests.examples.RestWhiteboardExampleTest ‑ testWhiteboard
org.apache.karaf.itests.examples.RestWhiteboardExampleTest ‑ testWhiteboardWithJerseyClient
org.apache.karaf.itests.examples.RestExampleTest ‑ testWhiteboard
org.apache.karaf.itests.examples.RestExampleTest ‑ testWhiteboardWithHttpClient
org.apache.karaf.itests.examples.RestExampleTest ‑ testWhiteboardWithJerseyClient

♻️ This comment has been updated with latest results.

@jbonofre

Copy link
Copy Markdown
Member

@holgerfriedrich Do you want to include this in 4.5.0 (the PR is still in draft mode)? Or are you ok to include later?

@holgerfriedrich

holgerfriedrich commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor Author

@jbonofre It depends on (and right now also still contains all commits from) #3088, that's why I opened it as draft.

From my perspective, it is ready for use.
Feel free to pick e3580ea on top of 3088, or I can rebase once 3088 is merged.

I am also fine to shift it to next release.

@jbonofre

Copy link
Copy Markdown
Member

@holgerfriedrich I'm updating and I will merge #3088. Then I will rebase this one to (removing draft).

@jbonofre

Copy link
Copy Markdown
Member

@holgerfriedrich I merged #3088. I propose to rebase this one and remove the "draft mode".

@jbonofre

Copy link
Copy Markdown
Member

I'm rebasing now.

Builds on apache#3088: Jersey 3.x needs jakarta.ws.rs-api 3.1.0 and the
Jakarta Jackson provider.

- client-jersey, client-cxf: jakarta.ws.rs-api 3.1.0
- client-jersey: jackson-jakarta-rs-json-provider; use
  JerseyClientBuilder, as the ServiceLoader lookup does not work in OSGi
- client-jersey feature: install the jackson-jakarta-rs bundles
- RestExampleTest: enable whiteboard tests (HTTP and Jersey clients),
  keep blueprint/SCR ignored (no CXF 4 Karaf features, see apache#2461)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@jbonofre
jbonofre marked this pull request as ready for review November 21, 2026 10:46
@jbonofre
jbonofre force-pushed the pr-rest-example-tests-3088 branch from e3580ea to 2c04c6d Compare November 21, 2026 10:46
@jbonofre

Copy link
Copy Markdown
Member

Ready 😄

I will merge as soon as CI is green 😄

@holgerfriedrich

Copy link
Copy Markdown
Contributor Author

LGTM

@jbonofre
jbonofre merged commit d19c7ed into apache:main Nov 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants