Skip to content

RAT-559: fix DocumentName issues in archives/on Windows#674

Open
Claudenw wants to merge 5 commits into
masterfrom
fix-DocumentName-issues
Open

RAT-559: fix DocumentName issues in archives/on Windows#674
Claudenw wants to merge 5 commits into
masterfrom
fix-DocumentName-issues

Conversation

@Claudenw

@Claudenw Claudenw commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Fix for RAT-559

fixed DocumentName and DocumentName.Builder and added extensive testing to validate correctness.

@Claudenw Claudenw self-assigned this Jun 9, 2026
@Claudenw Claudenw added bug java Pull requests that update Java code labels Jun 9, 2026
@ottlinger ottlinger changed the title fix DocumentName issues RAT-559: fix DocumentName issues in archives/on Windows Jun 9, 2026
@Claudenw Claudenw marked this pull request as draft June 9, 2026 13:59
@ottlinger

Copy link
Copy Markdown
Contributor

@Claudenw test failure seem to address the problem you tried to self:

Expecting value to be true but was false
Error:    ReporterTest.testXMLOutput:223 Could not find exactly one/rat-report/resource[@name='/.hiddenDirectory'] ==> expected: <1> but was: <0>
Error:    ArgTests.outputFileNameNoDirectoryTest:65 
expected: "D:\a\creadur-rat\creadur-rat\apache-rat-core\rat.txt"
 but was: "C:\a\creadur-rat\creadur-rat\apache-rat-core\rat.txt"
Error:    ArgTests.outputFileNameNoDirectoryTest:65 
expected: "D:\a\creadur-rat\creadur-rat\apache-rat-core\rat.txt"
 but was: "C:\a\creadur-rat\creadur-rat\apache-rat-core\rat.txt"
Error:    ArgTests.outputFileNameNoDirectoryTest:65 
expected: "D:\a\creadur-rat\creadur-rat\apache-rat-core\target\rat.test"
 but was: "C:\a\creadur-rat\creadur-rat\apache-rat-core\target\rat.test"
Error:    GitIgnoreBuilderTest.test_RAT_335:137 
expected: "matcherSet(or('included dir1/.gitignore', 'included .gitignore'), or('excluded dir1/.gitignore', **/.gitignore, 'excluded .gitignore'))"
 but was: "not(**/.gitignore)"
Error:    GitIgnoreBuilderTest.test_global_gitignore:175 
expected: "matcherSet(or('included dir1/.gitignore', 'included .gitignore', 'included global gitignore'), or('excluded dir1/.gitignore', **/.gitignore, 'excluded .gitignore', 'excluded global gitignore'))"
 but was: "not(**/.gitignore)"
Error:    XmlReportFactoryTest.standardReport:94 Standard files ==> expected: <8> but was: <9>
Error:  Errors: 
Error:    ReportTest.integrationTest(String, Document) � TemplateInvocationValidation Configuration error: You must configure at least one set of arguments for this @ParameterizedTest

Claudenw added 3 commits June 16, 2026 16:00
# Conflicts:
#	apache-rat-core/src/main/java/org/apache/rat/configuration/XMLConfigurationReader.java
Add testing
Expanded testing to include multiple file system types
Fix recursion issue in DocumentName equals and compareTo
Additional migration to assertj
Changed File options to return DocumentName instances.
Cleaned up Sonar review issues
@Claudenw Claudenw force-pushed the fix-DocumentName-issues branch from 62d2521 to 00f3079 Compare June 22, 2026 07:13
@Claudenw Claudenw marked this pull request as ready for review June 22, 2026 07:14
@sonarqubecloud

Copy link
Copy Markdown

@Claudenw Claudenw requested a review from ottlinger June 22, 2026 07:33
@Claudenw

Copy link
Copy Markdown
Contributor Author

@ottlinger when you get a chance would you review this please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants