[fix] - bugs in shape decoration - #1
Open
saadejazz wants to merge 2 commits into
Open
Conversation
saadejazz
commented
Jun 26, 2026
- normalization should be along channel dimensions
- bg_mask is the inverse of inp_mask
+ normalization should be along channel dimensions + bg_mask is the inverse of inp_mask
Author
|
Hi, Thank you for open-sourcing your work. While reproducing the results, I came across a few potential bugs that you may want to look into. I also noticed that the method does not seem to achieve strong visual performance except when using the precomputed demo features. In particular, when I recompute the demo features using the provided code, the same demo no longer aligns properly, despite having a clear and unoccluded view. Could you please provide some context on this issue? Could be that the adaptation of Diff3F is not consistent? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.