Skip to content

refactor(session-ui): remove components nothing renders - #58619

Draft
kitlangton wants to merge 2 commits into
devfrom
session-ui-orphans
Draft

kitlangton wants to merge 2 commits into
devfrom
session-ui-orphans

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

What it does. Removes four session-ui components that nothing renders anymore: MessageNav, ToolStatusTitle, ToolCountSummary and ToolCountLabel, plus the message-part barrel that re-exported other modules. Each one still shipped CSS in the global session-ui stylesheet and showed up in the package exports.

How it works.

  1. Delete the components, their CSS, and the ToolCountSummary story.
  2. Drop their entries from package.json exports and styles/index.css.
  3. Drop the one import-boundaries.test.ts assertion that only read message-part.tsx.

No package imports any of these subpaths on dev or beta.

Risk. Low, because none of it is rendered. Two leftovers I left alone: the i18n key ui.messageNav.newMessage in packages/ui, and the timeline-stability perf spec, which already selected [data-component="tool-status-title"] and matched nothing.

The next dev→beta merge will need a few one-line conflict resolutions, all "keep the deletion":

  • beta has small token edits in these four CSS files (modify/delete);
  • beta adds a nearby genui line in package.json exports and in styles/index.css.

Proof. No media, since this only deletes code.

  • bun typecheck in packages/session-ui: clean
  • bun test src/import-boundaries.test.ts: 4 pass
  • bun run lint:changed, prettier: clean
  • pre-push bun turbo typecheck: 34/34 packages pass

MessageNav, ToolStatusTitle, AnimatedCountList/AnimatedCountLabel and the message-part barrel had no importers in app, gui-extensions or session-ui itself (on dev or beta); only one story kept them alive.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant