Skip to content

fix(processor): detect doom loops across messages instead of within current message #32089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JustSidus wants to merge 1 commit into from
Closed

fix(processor): detect doom loops across messages instead of within current message #32089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions packages/opencode/src/session/processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,21 +516,18 @@ export const layer = Layer.effect(
: value.providerMetadata,
}))

const parts = yield* MessageV2.parts(ctx.assistantMessage.id).pipe(
const msgs = yield* MessageV2.filterCompactedEffect(ctx.sessionID).pipe(

@gauntface gauntface Oct 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure of this, but I think filterCompactedEffect() loads all messages for the session, so it might be better to query the last X number of messages instead:

yield* MessageV2.page({
  sessionID: ctx.sessionID,
  limit: DOOM_LOOP_MESSAGES,
})

@gauntface gauntface Oct 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other concern I had when trying to implement a similar fix here is a scenario where an agent might be re-running a test with edits between to fix it.

  1. Edit
  2. BASH : run test
  3. Edit
  4. BASH : run test
  5. Edit
  6. BASH : run test

In this scenario you may not want the doom loop to trigger as there are parts between the matching tool calls.

Effect.provideService(Database.Service, database),
)
const recentParts = parts.slice(-DOOM_LOOP_THRESHOLD)
const matchingParts = msgs.flatMap((m) => m.parts).filter(
(part) =>
part.type === "tool" &&
part.tool === value.name &&
part.state.status !== "pending" &&
JSON.stringify(part.state.input) === JSON.stringify(input),
)

if (
recentParts.length !== DOOM_LOOP_THRESHOLD ||
!recentParts.every(
(part) =>
part.type === "tool" &&
part.tool === value.name &&
part.state.status !== "pending" &&
JSON.stringify(part.state.input) === JSON.stringify(input),
)
) {
if (matchingParts.length < DOOM_LOOP_THRESHOLD) {
return
}

Expand Down
Loading