Skip to content

fix(desktop): open local file paths with file:// scheme #19146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jecruz wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(desktop): open local file paths with file:// scheme #19146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/desktop-electron/src/main/ipc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { execFile } from "node:child_process"
import { BrowserWindow, Notification, app, clipboard, dialog, ipcMain, shell } from "electron"
import * as path from "node:path"
import type { IpcMainEvent, IpcMainInvokeEvent } from "electron"

import type { InitStep, ServerReadyData, SqliteMigrationProgress, TitlebarTheme, WslConfig } from "../preload/types"
Expand Down Expand Up @@ -127,7 +128,16 @@ export function registerIpcHandlers(deps: Deps) {
)

ipcMain.on("open-link", (_event: IpcMainEvent, url: string) => {
void shell.openExternal(url)
// Convert local file paths to file:// URLs
// If the URL doesn't have a scheme (not http://, https://, file://, etc.),
// treat it as a local file path and convert to file://
let finalUrl = url
if (!url.match(/^[a-zA-Z][a-zA-Z\d+.-]*:/)) {
// Resolve relative paths to absolute paths
const absolutePath = path.resolve(url)
finalUrl = `file://${absolutePath}`
}
void shell.openExternal(finalUrl)
})

ipcMain.handle("open-path", async (_event: IpcMainInvokeEvent, path: string, app?: string) => {
Expand Down
Loading