refactor(cli): allow custom config setting for cli network options and improve docs#19107
Open
OpeOginni wants to merge 1 commit intoanomalyco:devfrom
Open
refactor(cli): allow custom config setting for cli network options and improve docs#19107OpeOginni wants to merge 1 commit intoanomalyco:devfrom
OpeOginni wants to merge 1 commit intoanomalyco:devfrom
Conversation
1000p
reviewed
Mar 25, 2026
|
|
||
| export async function resolveNetworkOptions(args: NetworkOptions) { | ||
| const config = await Config.global() | ||
| const globalConfig = await Config.global() |
There was a problem hiding this comment.
I wonder, isn't there any helper that "merges" the configs based on the Precidence Order defined here https://opencode.ai/docs/config#precedence-order
I can imagine that this can be a recurring issue.
Contributor
Author
There was a problem hiding this comment.
I dont know if a merge would be the best, rather it just takes the complete server config of either the Global or the Custom one set with the var.
Would be weird if some parts of the server are in one config, then mixed with the other. But the team would be best to make that choice, just made the PR with what seemed to make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #19078
Type of change
What does this PR do?
Adds support for custom config set by
OPENCODE_CONFIGvar when setting network options for cli commands likeserveandweb.Improves the docs stating the places where config for
serveandwebcomes from. The global config and the custom config.How did you verify your code works?
Tested on my local machine with he dev changes and check the docs frontend as well.
Screenshots / recordings
Checklist