fix: recover orphaned assistant messages after restart#19079
Open
Haohao-end wants to merge 2 commits intoanomalyco:devfrom
Open
fix: recover orphaned assistant messages after restart#19079Haohao-end wants to merge 2 commits intoanomalyco:devfrom
Haohao-end wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
158e88b to
45151a6
Compare
Author
|
Rebased on latest dev and all checks are now passing. Happy to make follow-up changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #19023
Type of change
What does this PR do?
This fixes a case where a session can stay stuck in a thinking state after the server restarts or a stream is interrupted.
Before this change, unfinished tool parts were only cleaned up at the end of the normal processor flow. If the process exited before that cleanup ran, the assistant message could remain incomplete and its tool parts could stay in
pendingorrunning.This change extracts that cleanup into a reusable session helper and reuses it in two places:
During recovery, unfinished tool parts are marked as
errorand the assistant message is completed. This reuses the existing message/part update flow so clients receive the normal update events instead of staying stuck.How did you verify your code works?
I verified the change by tracing the existing session update flow and confirming that the recovery path uses the same
updatePart()andupdateMessage()calls as the normal cleanup path.I was not able to run the full local typecheck in my current environment because the
typecheckscript depends ontsgo, which was not available (tsgo: command not found).Screenshots / recordings
Not a UI change.
Checklist