[criticalAY]

Note

Assisted-by: Opus 5.5

Purpose / Description

In study options, Rebuild, Empty and Unbury acted on the collection's selected deck instead of the deck the screen shows. If the screen was out of date, they could act on a deck that wasn't shown.

• Found while working on fix: deckpicker viewmodel errors #22504.

Fixes

• NA

Approach

They now use the shown deck (selectedDeckId), like Custom study, Deck options and Reminders already do.

How Has This Been Tested?

tests only

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Snapshot diff report vs main. Open screenshot-diff for diffs.

• CardBrowserScreenshotTest: 3 changes

All 3 changed screenshots

CardBrowserScreenshotTest

• long_cells_collapsed_again_compare.png
• long_cells_collapsed_compare.png
• long_cells_expanded_compare.png

[mikehardy]

Assisted-by: grok-4.7

Thank you. Matching these three actions to Custom study, Deck options, and Reminders is the right cut, and the regression tests actually change the collection selection after the panel has captured its deck.

Locally I rebased the single commit onto current main and did not force-push. Lint (lintAll, ktlintCheck, lint-rules:test), unit (jacocoUnitTestReport), and emulator (TEST_RELEASE_BUILD=true via run_emulator_tests.py on emulator-5556 / API35_GAPI) all passed on the rebased tip.

selectedDeckId is flowOfSelectedDeckId.value, initial 0L. The only writer is Collection.updateStateFromCollection(), which assigns study.deckId from decks.current(). refreshData() is withOpenColOrNull { updateStateFromCollection() }; a closed collection leaves the previous id in place. rebuildCram and emptyCram run under progressManager.withProgress, then undoableOp { sched.rebuildFilteredDeck(selectedDeckId) } or emptyFilteredDeck(selectedDeckId), then withCol { updateStateFromCollection() }. unbury launches on viewModelScope and only runs undoableOp { sched.unburyDeck(selectedDeckId) }. The new empty, rebuild, and unbury tests set up deck divergence after refresh and assert only the captured deck changes.

some acceptable findings, no action required, just leaving for posterity: after Empty or Rebuild, updateStateFromCollection() still reads decks.current(); unbury() still does not refresh haveBuried or the study state.

Screenshot changes have been detected, so leaving this for a good manual look.

[BrayanDSO]

Great catch