Repository navigation
fix(browser): ANR on saved saved search previews - #22824
david-allison merged 1 commit into
Conversation
Limit saved search names & queries to 500 characters, to prevent ANRs. Fixes 22820 Assisted-by: GPT-6.1-Sol xhigh
|
Snapshot diff report vs
All 1 changed screenshotsStandardSearchFragmentScreenshotTest
|
mikehardy
left a comment
There was a problem hiding this comment.
Assisted-by: GPT-6.1-Sol xhigh
Thank you — the stack lines up with this row, the click still submits the full saved search, and the new screenshot shows the long row clipped with the short row left whole.
Clean replay onto ankidroid/main with no push (act SHA unchanged). Local validation: lintAll/ktlintCheck/lint-rules:test, jacocoUnitTestReport, and TEST_RELEASE_BUILD=true emulator tests on emulator-5556 / API35_GAPI — all passed.
SavedSearchAdapter.getView now assigns ellipsize(500) for both name and query before the row is returned, so the measure that follows sees at most 500 characters plus …. Taps still call submitSavedSearch(item) and applySavedSearch(item) with the uncut SavedSearch. maxLines 2 and 3 with ellipsize="end" clip the preview after the string is already bounded. The Roborazzi compare shows “Long name” on two lines ending in an ellipsis, the nid: list on three lines ending in an ellipsis, and “Short name” / tag:short in full.
some acceptable findings, no action required, just leaving for posterity: “saved saved” in title; Purpose still template placeholder; pixel clip alone would not prove the 500-char cut; Manage saved searches still binds full strings without maxLines; Assisted-by does not say which part was AI-written.
Screenshot changes have been detected, so leaving this for a good manual look.

Note
Assisted-by: GPT-6.1-Sol xhigh
Purpose / Description
Describe the problem or feature and motivation
Fixes
Approach
Limit saved search names & queries to 500 characters, to prevent ANRs.
How Has This Been Tested?
Screenshot test added; no regression for the ANR
Checklist