Repository navigation
refactor: move deck selection helpers out of :AnkiDroid - #22769
Merged
criticalAY merged 1 commit intoOct 26, 2026
Merged
Conversation
david-allison
approved these changes
Oct 25, 2026
david-allison
left a comment
david-allison
left a comment
Member
There was a problem hiding this comment.
I don't like "below the app", be specific in the commit message
Other than that, looks great, Cheers.
Approving so you can merge after a wording change
david-allison
added
Needs Author Reply
The widget config screens need DeckSelectionDialog before they can move to :widgets, so its helpers that don't depend on :AnkiDroid move first. OnContextAndLongClickListener, AnalyticsDialogFragment, DeckFilters, BundleUtils, FragmentResult and TypedFilter move to :common:android. AccessibleSearchView needs :compat, so it moves to :anki-common. Packages are unchanged. Assisted-by: Claude Opus 5.5
criticalAY
force-pushed
the
refactor/deck-selection-helpers
branch
from
October 26, 2026 10:04
6f5df3d to
b4557a6
Compare
criticalAY
changed the title
criticalAY
changed the title
:AnkiDroid
criticalAY
removed
the
Needs Author Reply
criticalAY
enabled auto-merge
October 26, 2026 10:05
github-actions
Bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 5.5
Purpose / Description
The widget config screens need
DeckSelectionDialog. Its small helpers don't depend on the app, so they move down first.Fixes
Approach
OnContextAndLongClickListener,AnalyticsDialogFragment,DeckFilters,BundleUtils,FragmentResultandTypedFiltermove to:common:androidAccessibleSearchViewuses:compat, so it moves to:anki-commonPackages are unchanged, so callers don't change.
How Has This Been Tested?
Tests and no duplicate classes
Checklist