[criticalAY]

Note

Assisted-by: Claude Opus 5.5

Purpose / Description

Adopt the ViewModel progress for the Instant Note Editor.

It also fixes a bug on main: Save could be tapped again while a note was saving, which added the same note twice and broke the collection until the app restarted.

Fixes

• Part of architecture: support withProgress in ViewModels #19460

Approach

commits

How Has This Been Tested?

most of the users wont see this but nice to have?

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

LGTM, cheers!

[mikehardy]

Assisted-by: grok-4.7

Thank you — the follow-up commits address what the earlier reviews asked for, and the shared test helper lands in the right place.

Prep rebased seven commits cleanly onto current main without pushing (push: no).

Local validation: lintAll, ktlintCheck, and lint-rules:test; unit via jacocoUnitTestReport; emulator with TEST_RELEASE_BUILD=true on assigned emulator-5556 / API35_GAPI.

Reviewed at ff8e1816: InstantEditorViewModel reports InstantEditorProgress.SAVING_NOTE through ProgressManager, and Save paths ignore taps while progress is active, while finishing, or when the no-cloze confirmation would re-read fields. checkAndSave extracts once; the warning’s Save calls saveNoteWithProgress(skipClozeCheck = true) so editorNote stays the validated snapshot. Activity tests cover double-save during active progress, double-tap on the warning, ignored saves during queued insertion, finish guard, and back during save; the no-cloze snapshot test asserts confirmation saves the fields that triggered the warning.

some acceptable findings, no action required, just leaving for posterity: Approach says “commits” while messages already describe each step; Accessibility Scanner unchecked though screenshot shows saving state; back-during-save test uses original share text so discard dialog timing matches the old window; Assisted-by trailers do not spell out which parts were tool-written.

[criticalAY]

I will squash the commits, then lets get this in