[snowtimeglass]

Note

Assisted-by: Gemini 3.5 Flash Lite

Purpose / Description

Enable users to open the dropdown menu by tapping the note type name displayed in the "To" card.

Fixes

• Fixes In "Change note type" screen, tapping the text of the selected note type in the "To" card doesn't open the selection list #22658

Approach

Adds an OnTouchListener to the CheckedTextView

• Sets the ripple hot spot on the "To" card
• Clicks the "To" card if the text area is tapped
• Ignores long-press

How Has This Been Tested?

Checked on Emulator (API 37.0)

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Snapshot diff report: Previous regressions were resolved by the latest commit.

[david-allison]

This seems complicated, are you sure there's not a simpler way?

[snowtimeglass]

I'm not entirely sure about it, but other simpler approaches I tried didn't work.
For example, I tried an approach using isClickable = false to disable clicking on the checkedTextView and pass touch events directly to the parent card, but it didn't work.

[snowtimeglass]

Thank you, but it doesn't quite seem to do enough. For now, I expect that touching the selected note type area triggers a ripple, just like touching other area of the "To" card.

[snowtimeglass]

Thank you, but I'm not sure whether setting the tooltip on the entire "To" card (rather than just the selected note type name area) would be a desirable change in terms of UI. It might be a bit excessive. What do you think?

[david-allison]

I feel it's fine personally. @ZornHadNoChoice ?

[ZornHadNoChoice]

Tapping anywhere within the blue box should open the drop down menu in my opinion.

Also, the weird black tooltip shouldn't be visible, obviously. [Edit: I realized now that it's the note type's name and it appears on long pressing. I don't care about it then.]

[snowtimeglass]

Thanks for the feedback. I'll go with that, then.

To keep things consistent, I'm going to set the tooltip on the entire "From" card as well.

 private fun setupNoteTypeSpinner(binding: DialogChangeNoteTypeBinding) {
+         binding.fromCard.setTooltipTextCompat(viewModel.inputNoteType.name)
          binding.CardEditorModelText.text = BidiFormatter.getInstance().unicodeWrap(viewModel.inputNoteType.name)
-         binding.CardEditorModelText.setTooltipTextCompat(viewModel.inputNoteType.name)

[david-allison]

Cheers!

[mikehardy]

Assisted-by: grok-4.7-medium

Thanks for the change-note-type touch target work.

No local prep run this pass — required GitHub Actions unit matrix legs failed before prep (JUnit Tests (ubuntu run 1) and JUnit Tests (windows run 1)).

Please get those required unit jobs green on the current tip; I will re-run full local prep once CI is passing.

[david-allison]

Rebased on main; should fix the tests

rebased