Skip to content

fix(change-notetype): edge to edge - #22112

Merged
lukstbit merged 2 commits into
ankidroid:mainfrom
criticalAY:fix/change-notetype-edge-to-edge
Sep 28, 2026
Merged

lukstbit merged 2 commits into
ankidroid:mainfrom
criticalAY:fix/change-notetype-edge-to-edge

Conversation

@criticalAY

Copy link
Copy Markdown
Contributor

Note

Assisted-by: Opus 5.5

Purpose / Description

Fixes

How Has This Been Tested?

Before:
image

After:
image

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY
criticalAY force-pushed the fix/change-notetype-edge-to-edge branch from d866bd0 to e915b43 Compare September 26, 2026 19:53
david-allison

This comment was marked as resolved.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Sep 26, 2026
@criticalAY
criticalAY force-pushed the fix/change-notetype-edge-to-edge branch from e915b43 to e5e148d Compare September 27, 2026 19:58
Assisted-by: Opus 5.5
@criticalAY
criticalAY force-pushed the fix/change-notetype-edge-to-edge branch from e5e148d to ba6b46c Compare September 27, 2026 20:15

@david-allison david-allison left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I prod on a follow-up issue for screenshot tests?

EDIT: resolved

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Needs Review labels Sep 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • ChangeNoteTypeDialogScreenshotTest: 4 changes
All 4 changed screenshots

ChangeNoteTypeDialogScreenshotTest

  • gesture_navigation_compare.png
  • landscape_compare.png
  • portrait_compare.png
  • portrait_cutout_compare.png

@lukstbit lukstbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 28, 2026
@lukstbit
lukstbit added this pull request to the merge queue Sep 28, 2026
Merged via the queue into ankidroid:main with commit 138ddbf Sep 28, 2026
24 of 25 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 28, 2026
@github-actions github-actions Bot added this to the 2.26 release milestone Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement edge to edge for 'Change notetype'

3 participants