Skip to content

docs(libanki): defaultsForAdding & defaultDeckForNoteType - #22111

Merged
lukstbit merged 2 commits into
ankidroid:mainfrom
david-allison:20497-4
Sep 27, 2026
Merged

lukstbit merged 2 commits into
ankidroid:mainfrom
david-allison:20497-4

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: GPT-6 (with lots of human guidance)

Fixes

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread libanki/src/main/java/com/ichi2/anki/libanki/Collection.kt Outdated
@criticalAY criticalAY added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 26, 2026
david-allison and others added 2 commits September 26, 2026 21:56
Part of 20497

Assisted-by: GPT-6 (with lots of rounds of feedback)

Co-authored-by: Ashish Yadav <48384865+criticalAY@users.noreply.github.com>
Part of 20497

Assisted-by: GPT-6 (with lots of rounds of feedback)
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 27, 2026
@lukstbit
lukstbit added this pull request to the merge queue Sep 27, 2026
Merged via the queue into ankidroid:main with commit afb4b2d Sep 27, 2026
23 of 24 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 27, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone Sep 27, 2026
@david-allison
david-allison deleted the 20497-4 branch September 27, 2026 09:41
@mikehardy mikehardy modified the milestones: 2.25 release, 2.26 release Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants