fix(settings): edge to edge toolbar color - #22096
Open
david-allison wants to merge 1 commit into
Open
david-allison wants to merge 1 commit into
david-allison wants to merge 1 commit into
Conversation
Contributor
|
Snapshot diff report vs
All 10 changed screenshotsPreferencesScreenshotTest
|
david-allison
marked this pull request as draft
September 26, 2026 15:57
Keep the top inset inside the toolbar so the collapsing scrim covers the status bar. Increase both toolbar heights to preserve the scroll range and touch targets. Adjust the scrim visibility threshold by the same inset. Otherwise, a 48dp cutout prevents the scrim from appearing even when fully collapsed. Reproduced this in settingsPanelSystemBarsChange's fullscreen cutout screenshot. Validated eight screenshot cases on phones and tablets in light and dark themes, plus Kotlin formatting and Android lint. GPT-6 assisted with implementation, screenshot tests, and self-review. Fixes 22087 Assisted-by: GPT-6
david-allison
force-pushed
the
22087
branch
from
September 26, 2026 16:18
01c5386 to
6d4a662
Compare
david-allison
marked this pull request as ready for review
September 26, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: GPT-6
Fixes
How Has This Been Tested?
Checklist