fix(bottom nav): handle edge-to-edge - #21847
Open
ShaanNarendran wants to merge 1 commit into
Open
ShaanNarendran wants to merge 1 commit into
ShaanNarendran wants to merge 1 commit into
Conversation
Contributor
Author
Contributor
|
Snapshot diff report vs
All 4 changed screenshotsDeckPickerScreenshotTest
|
Member
|
You may wish to split these comments into separate PRs:
For these regressions, adding screenshot tests would be awesome, do feel free to defer the screenshot work to me if you wish. |
david-allison
requested changes
Sep 14, 2026
david-allison
left a comment
Member
There was a problem hiding this comment.
Should have requested changes here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Assisted-by: GPT 5.6 for research
Purpose / Description
This PR adds the necessary insets so that there are no issues with displaying the nav bar in edge-to-edge displays.
Fixes
Approach
Adds the necessary insets, we calculate a fallback value for the initial height on the first run so that there are no rendering issues and then we later update it to the measured value.
How Has This Been Tested?
Checklist
Please, go through these checks before submitting the PR.