Skip to content

fix(bottom nav): handle edge-to-edge - #21847

Open
ShaanNarendran wants to merge 1 commit into
ankidroid:mainfrom
ShaanNarendran:fix/bottom-nav-edge-to-edge
Open

ShaanNarendran wants to merge 1 commit into
ankidroid:mainfrom
ShaanNarendran:fix/bottom-nav-edge-to-edge

Conversation

@ShaanNarendran

@ShaanNarendran ShaanNarendran commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Note

Assisted-by: GPT 5.6 for research

Purpose / Description

This PR adds the necessary insets so that there are no issues with displaying the nav bar in edge-to-edge displays.

Fixes

Approach

Adds the necessary insets, we calculate a fallback value for the initial height on the first run so that there are no rendering issues and then we later update it to the measured value.

How Has This Been Tested?

image1 image0

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@ShaanNarendran ShaanNarendran added the GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors label Sep 14, 2026
@ShaanNarendran

Copy link
Copy Markdown
Contributor Author

This also fixes the display everywhere including more, forgot to mention.
image

@github-actions

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • DeckPickerScreenshotTest: 4 changes
All 4 changed screenshots

DeckPickerScreenshotTest

  • hierarchy_lines_collapsed_compare.png
  • hierarchy_lines_compare.png
  • hierarchy_lines_deep_nesting_compare.png
  • hierarchy_lines_many_siblings_compare.png

@david-allison

david-allison commented Sep 14, 2026

Copy link
Copy Markdown
Member

You may wish to split these comments into separate PRs:

  • Statistics needs handling
  • More needs handling in landscape mode (obscured by the notch on the left of my phone)

For these regressions, adding screenshot tests would be awesome, do feel free to defer the screenshot work to me if you wish.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Sep 14, 2026

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have requested changes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors Needs Author Reply Waiting for a reply from the original author Needs Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge to edge: Fix more fragment destination (bottom nav bar)

2 participants