Skip to content

build(deps): bump compileSdk to 37 - #21679

Open
david-allison wants to merge 5 commits into
ankidroid:mainfrom
david-allison:21672-compile-sdk-37
Open

david-allison wants to merge 5 commits into
ankidroid:mainfrom
david-allison:21672-compile-sdk-37

Conversation

@david-allison

@david-allison david-allison commented Sep 1, 2026

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Fable 5

Purpose / Description

Standard compileSdk bump - easy one

Fixes

Approach

Firstly perform some refactorings:

  • showSoftInput - SHOW_IMPLICIT is deprecated, so move calls which use this to Compat
    • And add an extension method - the code was ugly compared to other calls
  • Fix a WrongConstants in WindowInsetsController.hide

Then, we have a trivial version bump, with compileSdkMinor required. See Learning

How Has This Been Tested?

⚠️ Trusting CI

Learning (optional, can help others)

No good link on compileSdkMinor: https://android-developers.googleblog.com/2024/10/android-sdk-release-update.html

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
david-allison force-pushed the 21672-compile-sdk-37 branch 2 times, most recently from 32c447e to 11bd767 Compare September 1, 2026 00:47
@david-allison
david-allison marked this pull request as draft September 1, 2026 01:29
@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Sep 1, 2026
@david-allison
david-allison force-pushed the 21672-compile-sdk-37 branch 2 times, most recently from ad6fee6 to eb6ad1d Compare September 1, 2026 08:44
@david-allison david-allison added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Sep 1, 2026
@david-allison
david-allison marked this pull request as ready for review September 1, 2026 09:24
@david-allison

david-allison commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

Blocked on

Recommended action: Update this project's version of the Android Gradle plugin to one that supports [compileSdk] 37, then update this project to use compileSdk of at least 37.

-- https://github.com/ankidroid/Anki-Android/actions/runs/33323535173/job/99289560127?pr=21551

@david-allison david-allison added the Blocked by dependency Currently blocked by some other dependent / related change label Sep 4, 2026
@david-allison
david-allison marked this pull request as draft September 4, 2026 19:21
Prep for compileSdk 37: `SHOW_IMPLICIT` is deprecated in API 37.
The flag is a no-op from Android 16, so drop it on API 36+

Part of 21672

Assisted-by: Claude Fable 5
Simplifies call sites

Part of 21672

Assisted-by: Claude Fable 5
Prep for compileSdk 37: its annotation metadata declares an empty
IntDef for the platform `InsetsType` typedef, so lint reports a
`WrongConstant` false positive on `WindowInsetsController.hide`.
The androidx annotations are unaffected

Part of 21672

Assisted-by: Claude Fable 5
Robolectric 4.16.1 supports a max of SDK 36

Assisted-by: Claude Fable 5
SDK 37 is the first release under 'major.minor' SDK versioning: the
platform ships as `android-37.0`, so `compileSdkMinor` must be set for
the target to resolve

Fixes 21672

Assisted-by: Claude Fable 5
@david-allison
david-allison marked this pull request as ready for review September 14, 2026 20:07
@david-allison david-allison removed the Blocked by dependency Currently blocked by some other dependent / related change label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump to compileSdk 37

1 participant