feat: About in an empty-state footer across the deck, Modal shared in deck-kit - #286
Open
andraderaul wants to merge 2 commits into
Open
feat: About in an empty-state footer across the deck, Modal shared in deck-kit#286andraderaul wants to merge 2 commits into
andraderaul wants to merge 2 commits into
Conversation
ASCII//Convert's `about` trigger leaves the header for a new ultra-thin footer that also carries the `source code →` / `author →` links; GLITCH//Studio gains the same footer plus its own About modal (no AI-scan section — the one thing it doesn't share). The footer shows only before a Source loads, so the Control Strip owns the bottom edge once work starts and a footer under it can't invite a mis-tap. The Modal primitive crosses the seam into deck-kit (ADR 0014): it was ascii's local dialog and glitch's About is the second real caller, so it moves verbatim over the already-shared useDialog hook. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A centered Modal with no height bound overflowed the viewport on a short screen — a tall dialog pushed its own title past the top edge with no way to scroll to it. Pad the overlay and cap the panel to the viewport height with internal scroll, so the title stays reachable and the body scrolls. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
ASCII//Convert's about trigger leaves the crowded header for a new ultra-thin footer. The footer also carries the
source code →/author →attribution links that used to hide inside the About modal, and it shows only on the empty state — once a Source loads the Control Strip owns the bottom edge, and a footer under it would just invite a mis-tap.GLITCH//Studio gains the same footer plus its own About modal (describes the glitch pipeline; keeps
made with ai; dropsai scan— the one thing it doesn't share with ASCII).The
Modalprimitive was ASCII-local; glitch's About is the second real caller, so it crosses the seam into@cyberdeck/deck-kit/ui(ADR 0014) over the already-shareduseDialoghook. It also gains a mobile fix: a tall dialog now caps to the viewport and scrolls internally instead of clipping its own title on a short screen.Commits
feat: the footer + About across both apps, and the verbatim Modal extraction into deck-kit (a pure rename — no behavior change, so the move stays auditable per ADR 0014).fix(deck-kit): the mobile scroll fix, landed separately on top of the verbatim move.Two-axis code review
footer.tsxacross the two apps is the deliberate per-app copy pattern (ADR 0014), documented in the glitch footer's JSDoc.Test plan
app.test.tsx) and the Modal's mobile overflow classes (deck-kitmodal.test.tsx).Changesets
@cyberdeck/asciipatch ·@cyberdeck/glitchpatch ·@cyberdeck/deck-kitminor (newModalexport + mobile fix).🤖 Generated with Claude Code