Skip to content

solutions/reference-design/eval-ad7490-ardz: Added EVAL-AD7490-ARDZ Page - #539

Closed
Carlian275 wants to merge 1 commit into
analogdevicesinc:mainfrom
Carlian275:eval-ad7490-ardz
Closed

solutions/reference-design/eval-ad7490-ardz: Added EVAL-AD7490-ARDZ Page#539
Carlian275 wants to merge 1 commit into
analogdevicesinc:mainfrom
Carlian275:eval-ad7490-ardz

Conversation

@Carlian275

Copy link
Copy Markdown
Contributor

Type

  • Documentation
  • Bug fix
  • New feature
  • Continuous integration

Checklist

Signed-off-by: Carlian275 <carlian.gamutan@analog.com>
@Carlian275

Copy link
Copy Markdown
Contributor Author

Hello @gastmaier!

This is intended for an upcoming product release on analog.com and we're currently completing the web page. The Tech Lead/Reviewer had no more comments for the User Guide. Please help us publish this when you have time.

We'd appreciate if we could have the UG live before the actual launch.

Thank you for your usual support.

--Ian

@gastmaier gastmaier added the llm review Request a review from a LLM Reviewer label Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

LLM review

This series adds the EVAL-AD7490-ARDZ reference-design page.

run: 30244518684

41ffa81 - Added EVAL-AD7490-ARDZ Page

Directory name typo: the folder is docs/solutions/reference-designs/eval-ad4790-ardz
(digits transposed), while the commit subject, the .. _eval-ad7490-ardz:
label and every :adi: role in the page refer to AD7490. It still builds
because the section is picked up through a toctree-preview glob, but the
folder should be eval-ad7490-ardz to match.

Dangling/duplicate images: images/eval-ad7490ardz Top.png and
images/eval-ad7490ardz Angle.png (note the space in the filename) are
unused duplicates of the already-referenced top/angle-view images
(.github/scripts/dangling.py --dry-run confirms). The referenced
top/angle-view images are also upper-case (EVAL-AD7490-ARDZ_top-*),
flagged by .github/scripts/case.py --dry-run.

Wrong figure reference: "Evaluating Bipolar Test Signals" says
"connect the input to the VIN15 (Bipolar) test point (see Figure 4)". With
numfig enabled, Figure 4 is actually "PMOD SPI Interface" — the figure
that shows TP16/TP59 is Figure 5 ("EVAL-AD7490-ARDZ Test Points"). Replaced
the hard-coded number with a :numref: cross-reference.

Layout: the top/angle-view images are placed side by side with a
list-table used purely for layout; converted to the grid directive per
the layout guidelines, for responsive small-screen behavior.

Also fixed a subject/verb-agreement nit ("Table 2 and table 3 summarizes")
and stripped trailing whitespace.

CI warnings

The Vale.Terms failures for VDD/UNO/PMOD are generic style
suggestions, not project rules; VDD/VDRIVE/VIN15 are pin/net names and
should stay uppercase. Treated as noise, no change made. Note the CI notes
only show a subset of the Vale.Terms hits; a local re-run also surfaces
MOSI, CTRL, tinyIIOd, no-OS for the same reason — none of these
block the check-doc job.

Verification data

Datasheet ad7490.pdf was obtained from the ADI docling mirror
(media/en/technical-documentation/data-sheets/ad7490.md), and used to
confirm the 12-bit/16-channel SAR ADC, 2.7 V-5.25 V supply, and 1 MSPS
throughput claims in the Overview/Hardware Description sections. The page
was also built with adoc serve --once --sparse solutions/reference-designs/eval-ad7490-ardz before/after the fixes
(clean, no new warnings), and the rendered HTML caption-number spans were
inspected to confirm the Figure 4/5 mismatch and its fix.

Suggested patches

Apply the suggested patches with:

cd path/to/repository
export GITHUB_TOKEN=ghp_***
apply-patches --repo=analogdevicesinc/documentation 30244518684
Install instructions

The following one-liner installs the script if not present already:

curl -fSsL "https://raw.githubusercontent.com/analogdevicesinc/doctools/refs/heads/main/ci/scripts/apply-patches.sh"      -o ~/.local/bin/apply-patches.sh &&   grep -q "/apply-patches.sh" ~/.bashrc || echo "source ~/.local/bin/apply-patches.sh" >> $_ ; . $_

More information at AI Usage.

@Carlian275 Carlian275 closed this Jul 27, 2026
@Carlian275
Carlian275 deleted the eval-ad7490-ardz branch July 27, 2026 07:56
@Carlian275

Copy link
Copy Markdown
Contributor Author

The new PR is here #553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llm review Request a review from a LLM Reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants