Skip to content

Add clarifying comment to vue compiler config - #8

Merged
alonelish merged 1 commit into
mainfrom
claude/modest-mccarthy-c2H7h
Jun 2, 2026
Merged

Add clarifying comment to vue compiler config#8
alonelish merged 1 commit into
mainfrom
claude/modest-mccarthy-c2H7h

Conversation

@alonelish

Copy link
Copy Markdown
Owner

Summary

Small documentation-only change: adds a // Vue compiler configuration comment above the vue block in nuxt.config.ts for readability.

Changes

  • nuxt.config.ts: added a clarifying comment, no behavioral change.

https://claude.ai/code/session_01LVGVWgHtoE7BTRkJZogkd3


Generated by Claude Code

@alonelish
alonelish merged commit 56acca5 into main Jun 2, 2026
@alonelish

Copy link
Copy Markdown
Owner Author

❌ Workflow Failed: On PR Merge

Run: #26805789125
Branch: claude/modest-mccarthy-c2H7h

Failed Job: run-on-merge

Step: Do something (step #3)

Error Output

/home/runner/work/_temp/0ca956c4-770c-4668-953e-02259d40c527.sh: line 1: unexpected EOF while looking for matching `"'
Process completed with exit code 2.

Root Cause

The workflow step uses a shell echo with double quotes wrapping GitHub expression interpolation:

run: echo "PR #${{ github.event.pull_request.number }} was merged into ${{ github.event.pull_request.base.ref }}"

When this workflow runs on the pull_request: closed event and GitHub expands the expressions, the resulting shell script has an unmatched double quote — likely because one of the ${{ }} expressions expanded to an empty or unexpected value containing a newline/quote, breaking the bash string literal.

Suggested Fix

Wrap the run command more defensively, or use single quotes for the static parts:

- name: Do something
  run: |
    echo "PR #${{ github.event.pull_request.number }} was merged into ${{ github.event.pull_request.base.ref }}"

Using the | (literal block scalar) ensures the YAML parser doesn't interfere with the quoting. Alternatively, assign values to environment variables:

- name: Do something
  env:
    PR_NUMBER: ${{ github.event.pull_request.number }}
    BASE_REF: ${{ github.event.pull_request.base.ref }}
  run: echo "PR #${PR_NUMBER} was merged into ${BASE_REF}"

The env approach is the safest since it avoids any shell injection or quoting issues from expression expansion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants