[VARIANT] Fix "variant is null" data skipping when pushVariantIntoScan = true#30
Open
harshmotw-db wants to merge 7 commits into
Open
Conversation
pushVariantIntoScan = true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
The PR intended to compile Delta-Spark with Spark 4.1 was failing on some variant data skipping related tests. This was because in Spark 4.1, shredding-related configs were enabled by default, and
pushVariantIntoScan = truewhich inserts a project node at the top.This PR fixes these issues by:
SkippingEligibleColumnin DataSkippingReader.scala.How was this patch tested?
Modified failing test to run with both -
pushVariantIntoScan = trueandfalseDoes this PR introduce any user-facing changes?
No. This PR just makes existing behavior compatible with Spark 4.1 which has shredded reads enabled by default.