Skip to content

Respect ignored uncommitted changes in version decoration - #1094

Open
dajiaohuang wants to merge 2 commits into
allegro:mainfrom
dajiaohuang:fix-ignore-uncommitted-version-decoration
Open

dajiaohuang wants to merge 2 commits into
allegro:mainfrom
dajiaohuang:fix-ignore-uncommitted-version-decoration

Conversation

@dajiaohuang

Copy link
Copy Markdown

Fixes #1065.

When ignoreUncommittedChanges is enabled, the predefined branch and commit-hash creators now rely on the resolved snapshot state instead of independently decorating any dirty working tree. This prevents misleading suffixes when uncommitted changes are explicitly ignored.

Validation: the two focused integration tests passed using temporary local Git repositories; no remote services were exercised by the tests.

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.57%. Comparing base (3fba97f) to head (c74d0a3).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ion/release/domain/PredefinedVersionCreator.groovy 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1094   +/-   ##
=========================================
  Coverage     58.57%   58.57%           
  Complexity      452      452           
=========================================
  Files            87       87           
  Lines          1871     1871           
  Branches        151      151           
=========================================
  Hits           1096     1096           
  Misses          715      715           
  Partials         60       60           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uncommitted changes ignored, but branch name still appended

2 participants