Improve o2checkcode#6221
Conversation
|
|
||
| # List of explicitely enabled C++ checks (make sure they are all green) | ||
| CHECKS="${O2_CHECKER_CHECKS:--*\ | ||
| ,modernize-avoid-bind\ |
There was a problem hiding this comment.
where is the default list of O2_CHECKER_CHECKS now maintained? I think such default list would be useful.
There was a problem hiding this comment.
See the description.
There was a problem hiding this comment.
My question is maybe more, why is it a good thing to delete the default list of checks from the recipe?
Initially the recipe was meant to be fully configured for ALICE and just typing aliBuild build o2checkcode should be enough. Now, it seems, you need to inject more information from the outside.
There was a problem hiding this comment.
Typing aliBuild build o2checkcode is still enough, plus the configuration is stored at a standard place which makes it reusable and modifiable independently of o2checkcode, alidist and aliBuild.
.clang-tidy. (Report if found.).clang-tidyif found. (Requires Update Clang-Tidy config file AliceO2Group/AliceO2#15321)O2_CHECKER_CHECKSis appended via the-checkscommand line option. (Report the provided value.)ALIBUILD_BASE_HASH.FIXME:
git diffcan fail silently, leading to an early exit due to an empty list of changed files. This is currently happening in the alidist fullCI check.