Skip to content

Improve o2checkcode#6221

Open
vkucera wants to merge 1 commit into
alisw:masterfrom
vkucera:o2checkcode
Open

Improve o2checkcode#6221
vkucera wants to merge 1 commit into
alisw:masterfrom
vkucera:o2checkcode

Conversation

@vkucera

@vkucera vkucera commented Apr 25, 2026

Copy link
Copy Markdown
Contributor
  • Allow auto-detect of .clang-tidy. (Report if found.)
  • Remove explicit list of Clang-Tidy checks.
  • Print enabled checks before running instead of all available.
  • Don't turn warnings into errors. Report both.
  • Fix unbound ALIBUILD_BASE_HASH.

FIXME: git diff can fail silently, leading to an early exit due to an empty list of changed files. This is currently happening in the alidist fullCI check.

@vkucera vkucera marked this pull request as ready for review June 1, 2026 13:16
@vkucera vkucera requested a review from a team as a code owner June 1, 2026 13:16
Comment thread o2checkcode.sh

# List of explicitely enabled C++ checks (make sure they are all green)
CHECKS="${O2_CHECKER_CHECKS:--*\
,modernize-avoid-bind\

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the default list of O2_CHECKER_CHECKS now maintained? I think such default list would be useful.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the description.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is maybe more, why is it a good thing to delete the default list of checks from the recipe?
Initially the recipe was meant to be fully configured for ALICE and just typing aliBuild build o2checkcode should be enough. Now, it seems, you need to inject more information from the outside.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typing aliBuild build o2checkcode is still enough, plus the configuration is stored at a standard place which makes it reusable and modifiable independently of o2checkcode, alidist and aliBuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants