Repository navigation
feat: support setup-only private endpoint access - #844
Conversation
|
Enclave skipped this draft pull request. It will run automatically when you mark the PR as Ready for review. |
|
@greptileai Please review the latest commit for ALIEN-450. |
|
|
@greptileai Please re-review latest head 627bee5. The setup-refresh finding is fixed, with regression coverage for initial setup, post-setup changes, and failed refreshes. |
Generated with `pnpm run generate:manager-api` (Speakeasy 1.680.11). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@greptileai Please review latest head c28b308, including the regenerated manager TypeScript SDK. The previous source head was rated 5/5. |
|
@greptileai Please review latest head 7a5db33. Rust CI found four existing operator test fixtures missing endpoint_access; this commit explicitly sets their Internet default. cargo test -p alien-operator --lib passes all 95 tests. Runtime and generated contracts are unchanged. |
|
@greptileai Please review latest head 15a7bb0. CI exposed stale package snapshots; regenerated 25 CloudFormation and 70 Terraform snapshots with INSTA_UPDATE=always cargo test -p alien-cloudformation -p alien-terraform --tests. All 396 active tests passed, including real artifact validators. Changes are expected endpoint-access fields only; no runtime changes. |
|
@greptileai Please review latest head d6b6c5d. Rust CI found a stale Helm stack-settings serialization expectation; it now includes the Internet endpoint-access default. All 45 alien-helm tests pass with Helm and kubeconform validation enabled. Test-only change; runtime and generated contracts are unchanged. |
|
@greptileai Please review current head ce5c135. The latest commit regenerates the two Helm snapshots to include the Internet endpoint-access default. No runtime changes. Full CI-filtered non-cloud validation is also running locally with --no-fail-fast. |
Add deployment-wide
endpointAccess(internetby default, orprivate) to setup settings. CloudFormation and Terraform expose typed inputs and deployment CLIs pass the choice through setup. Preflights reject unsupported targets and endpoint resource types; setup re-import refuses to change endpoint access. No application definition changes are required.Tracks ALIEN-450.
Validation:
cargo test -p alien-preflights --lib private_endpoints_reject_unsupported_targetspassed, including GCP and Worker refusal. Core TypeScript build passed./healthreturned HTTPS 200 with valid certificates. Private DNS returned private IPs and outside connections failed; Internet remained reachable outside.Generated with
pnpm --filter @alienplatform/core generate,pnpm generate:manager-rust-sdk, andpnpm generate:api-copy-openapi. Alon regenerated the manager TypeScript SDK withpnpm run generate:manager-apiinc28b30863; its build and wire round trips pass. The platform TypeScript SDK changes only during releases and does not need feature-branch regeneration.Round 2 validation on
ce5c135ad:c28b30863, and resolved the setup-refresh finding in627bee566. Overrides are checked after lock acquisition and fresh status; all three regression tests pass. Greptile rates the current head 5/5; the review thread is resolved.INSTA_UPDATE=always cargo test -p alien-cloudformation -p alien-terraform --tests, and Helm snapshots withINSTA_UPDATE=always cargo test -p alien-helm --tests. All 396 active CloudFormation/Terraform tests pass with real validators and no snapshot drift; Helm and operator tests pass too. Snapshot/fixture changes do not change runtime behavior.cargo nextest run --no-fail-fast --workspace --features alien-manager/openapi,alien-bindings/platform-sdk, usingCARGO_PROFILE_DEV_DEBUG=0 CARGO_PROFILE_TEST_DEBUG=0 CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=8. All 5,474 selected tests completed. After isolating the local Node host library from Bun, 5,467 pass; the remaining seven fail identically on main410d789724425cdd1b9ae3fb096b8aea9f2042ba: three Docker ARM64-builder tests, two Docker/OCI export tests, one Docker registry-proxy pull, and one systemd-dependent machine-service test. No tests or assertions were weakened. Debug build artifacts were cleaned afterward.🤖 Generated with Claude Code