Repository navigation
fix: recover failed setup resources before refresh - #548
Merged
Merged
Conversation
Greptile SummaryThe PR recovers setup-owned resources before re-entering direct initial setup while preserving runtime ownership of Live resources.
Confidence Score: 5/5The PR appears safe to merge, with no concrete correctness or security failures identified in the changed paths. The filtered helper reuses established retry behavior, limits direct setup recovery to setup-owned Frozen resources, and leaves Live resource failures under runtime ownership as intended.
|
| Filename | Overview |
|---|---|
| crates/alien-deploy-cli/src/commands/up.rs | Direct setup preparation now retries failed Frozen resources before entering InitialSetup while retaining the existing reconcile-and-release flow. |
| crates/alien-infra/src/core/state_utils.rs | Adds a lifecycle-filtered retry helper and a regression test confirming that Frozen failures recover while Live failures remain unchanged. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Acquire deployment and reload manager state] --> B{Direct setup preparation required?}
B -->|No| F[Run shared step loop]
B -->|Yes| C[Prepare direct setup metadata]
C --> D[Retry failed Frozen resources]
D --> E[Set status to InitialSetup]
E --> F
F --> G[Final reconcile and release]
Reviews (1): Last reviewed commit: "fix: retry failed setup resources before..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Direct setup refresh could re-enter
InitialSetupwhile a setup-owned resource still had a failed status from the previous lifecycle. Initial setup then classified the resource as terminally failed before its controller had a chance to reconcile.This change:
Frozenresources before a direct setup refreshLiveresources under runtime ownershipTests
refresh-failedresource while leaving a live failed resource unchangedLinear: ALIEN-629