Repository navigation
fix(cli): preserve release during setup refresh - #543
Merged
Merged
Conversation
Greptile SummaryThis PR reconstructs current and target release state after acquiring the deployment lock and ensures setup-preparation failures release that lock.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/alien-deploy-cli/src/commands/up.rs | Reconstructs release state under the acquired lock and adds mutually exclusive cleanup paths that release the deployment once on both preparation failure and normal completion. |
Sequence Diagram
sequenceDiagram
participant CLI
participant Manager
CLI->>Manager: Acquire deployment lock
Manager-->>CLI: Lock-protected deployment state
CLI->>Manager: Fetch current release
opt Desired release differs from current
CLI->>Manager: Fetch desired release
end
alt Setup preparation fails
CLI->>Manager: Release deployment lock
CLI-->>CLI: Return error
else Setup attempt completes
CLI->>Manager: Final reconcile
CLI->>Manager: Release deployment lock
end
Reviews (2): Last reviewed commit: "fix(cli): release setup lease on prepara..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
cargo test -p alien-deploy-cli commands::up::tests -- --nocapture