Repository navigation
feat: add quota outcomes and deployment error presentation - #1026
Open
alongubkin wants to merge 3 commits into
Open
alongubkin wants to merge 3 commits into
alongubkin wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Enclave skipped this draft pull request. It will run automatically when you mark the PR as Ready for review. |
alongubkin
added this pull request to stack #1031
October 14, 2026 08:50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@greptileai review |
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@greptileai review |
alongubkin
marked this pull request as ready for review
October 14, 2026 09:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud quota failures need to retain their provider identity and actionable guidance through saved deployment errors and CLI status. This first layer adds a pure quota model (identity, delta demand, observations and Pass/Fail/Warn/Unknown outcomes), optional structured results, and readable saved-error rendering. Cloud readers and check registration arrive in the next layer.
The model stays in
alien-preflights, reusing its existing runner and feature boundary instead of adding another crate. Default builds do not gain cloud-client dependencies. Unknown results never block; capacity credit requires observed held resources rather than a previous configured maximum. Existing retry and pre-cloud rejection teardown fixes are retained from #1011 and #1020 so rejected installations remain recoverable.Validation: 449 runtime-feature preflight library tests pass on this layer. The complete unsplit source passed all CI jobs, including supported
pnpm generateand generated-output drift checks. Independent current-head CI is green.Compatibility: added result/event fields default on read; existing protocol/controller versions and stored controller fields are unchanged. Real parent-created deployment update and mixed-version report and cleanup receipt. These are existing integrated-feature evidence, not a new run on this split commit. No cloud permissions are added by this layer.
Mapped race error and CLI output demonstrate preserved quota guidance; the provider mapper itself is in layer 2. No new cloud scenario was run for this split.
Layer validation:
cargo test -p alien-preflights --lib --features runtime-checkspassed 449 tests. The framework build caller is included with its event contract;cargo check -p alien-build --libalso passed on that layer.Warning delivery is best effort: a progress-handler error is logged without rejecting a valid build. The Azure memory-warning regression failed before the fix and passes now; both genuine build-rejection controls still pass. Greptile’s sole finding from its 4/5 review of
a1c4ad2d5is fixed in66dc4f237and resolved. Current-head re-review confirms the fix at 5/5.Current head
66dc4f237has green CI and Greptile 5/5. The warning-delivery finding is fixed and its thread resolved; the re-review reports no new findings.🤖 Generated with Claude Code