Skip to content

feat: add quota outcomes and deployment error presentation - #1026

Open
alongubkin wants to merge 3 commits into
mainfrom
alon/alien-5-quota-1-framework
Open

alongubkin wants to merge 3 commits into
mainfrom
alon/alien-5-quota-1-framework

Conversation

@alongubkin

@alongubkin alongubkin commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Cloud quota failures need to retain their provider identity and actionable guidance through saved deployment errors and CLI status. This first layer adds a pure quota model (identity, delta demand, observations and Pass/Fail/Warn/Unknown outcomes), optional structured results, and readable saved-error rendering. Cloud readers and check registration arrive in the next layer.

The model stays in alien-preflights, reusing its existing runner and feature boundary instead of adding another crate. Default builds do not gain cloud-client dependencies. Unknown results never block; capacity credit requires observed held resources rather than a previous configured maximum. Existing retry and pre-cloud rejection teardown fixes are retained from #1011 and #1020 so rejected installations remain recoverable.

Validation: 449 runtime-feature preflight library tests pass on this layer. The complete unsplit source passed all CI jobs, including supported pnpm generate and generated-output drift checks. Independent current-head CI is green.

Compatibility: added result/event fields default on read; existing protocol/controller versions and stored controller fields are unchanged. Real parent-created deployment update and mixed-version report and cleanup receipt. These are existing integrated-feature evidence, not a new run on this split commit. No cloud permissions are added by this layer.

Mapped race error and CLI output demonstrate preserved quota guidance; the provider mapper itself is in layer 2. No new cloud scenario was run for this split.

Layer validation: cargo test -p alien-preflights --lib --features runtime-checks passed 449 tests. The framework build caller is included with its event contract; cargo check -p alien-build --lib also passed on that layer.

Warning delivery is best effort: a progress-handler error is logged without rejecting a valid build. The Azure memory-warning regression failed before the fix and passes now; both genuine build-rejection controls still pass. Greptile’s sole finding from its 4/5 review of a1c4ad2d5 is fixed in 66dc4f237 and resolved. Current-head re-review confirms the fix at 5/5.

Current head 66dc4f237 has green CI and Greptile 5/5. The warning-delivery finding is fixed and its thread resolved; the re-review reports no new findings.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@enclave-ai

enclave-ai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Enclave skipped this draft pull request. It will run automatically when you mark the PR as Ready for review.

@alongubkin
alongubkin added this pull request to stack #1031 October 14, 2026 08:50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alongubkin

Copy link
Copy Markdown
Member Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the warning-delivery fix leaves failed checks blocking builds.

Summary

Adds provider-neutral quota outcomes, optional saved quota results, and clearer CLI warnings and deployment errors. It also preserves deployment retries and allows cleanup when a first deployment was rejected before setup.

  • Quota checks report whether extra demand fits an observed limit.
  • Build-time preflight warnings show up in both CLI views.
  • Saved deployment errors show quota guidance and validation details.
  • Failed deployments keep their retry request when the manager skips setup.
  • Empty first deployments can be deleted without runtime credentials.

Reviews (3) · Last reviewed commit: "fix: keep preflight warning delivery non..." · Reviewed by Greptile

Comment thread crates/alien-build/src/lib.rs Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alongubkin

Copy link
Copy Markdown
Member Author

@greptileai review

@alongubkin
alongubkin marked this pull request as ready for review October 14, 2026 09:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant