Repository navigation
fix: use the AWS Query protocol for CloudWatch metrics - #1017
Merged
alongubkin merged 2 commits intoOct 14, 2026
Merged
alongubkin merged 2 commits into
alongubkin merged 2 commits into
Conversation
CloudWatch rejects JSON-target metric requests with UnknownOperationException. Send signed query forms, decode member-indexed XML lists and UTC timestamps, and preserve provider error codes. Replace serialization-only tests with actual request/response protocol checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Enclave skipped this draft pull request. It will run automatically when you mark the PR as Ready for review. |
Member
Author
|
@greptileai review |
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@greptileai review |
alongubkin
marked this pull request as ready for review
October 14, 2026 09:22
alongubkin
deleted the
alon/alien-1473-cloudwatch-metrics-client-sends-an-unsupported-json-protocol
branch
October 14, 2026 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics client sent JSON with an
X-Amz-Targetheader to CloudWatch's Query API. Real AWS returned HTTP 404<UnknownOperationException/>for GetMetricData; the AWS observer also uses this client for its ListMetrics availability probe.Send signed form requests with Action/Version and member-indexed parameters, then decode XML results, timestamps, dimensions, pagination and provider errors. Public request/response models stay unchanged. Reusing the existing signer and XML transport avoids adding an SDK dependency.
Validation: four HTTP protocol/error tests pass (
cargo test -p alien-aws-clients --lib aws::cloudwatch::tests). On the real E2E AWS target, the same Standard vCPU usage request now returns one Complete series (empty timestamps/values in the idle region), and ListMetrics returns 415 metrics successfully. Both calls are read-only; no cloud resources or quotas changed. The local real-read build enables system CA roots for the test environment and keeps TLS verification enabled. The HTTP regressions now cover multiple queries, samples, filters, metrics, dimensions and owning accounts, plus empty series and dimensions. Greptile's P2 list-edge-case finding is fixed in 0d00bb7; its previous 4/5 reviewed 2b5ffd7. Public request/response models and stored data stay unchanged; no permissions or dependencies were added.Current-head
0d00bb77cCI is green, mergeable, and Greptile re-reviewed it at 5/5, with no outstanding findings. The HTTP regression finding is resolved. Enclave passed, and the subsequent Greptile rerun also returned 5/5 on this head. Ready for review; no merge performed.🤖 Generated with Claude Code