feat(viewer): add back navigation to improve page traversal UX - #1217
feat(viewer): add back navigation to improve page traversal UX#1217hyy321 wants to merge 1 commit into
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 3 selected item(s). |
Qiyuanqiii
left a comment
There was a problem hiding this comment.
Looks good overall. The implementation matches the issue scope well: both sub-pages get an explicit parent navigation affordance, the existing breadcrumbs are preserved, the touch target and focus states are handled properly, and CI/CodeQL are green.
I don’t see any blocking code issues.
One thing to fix before merge: the PR disclosure says OpenAI Codex was used, but the repository guidelines require both the AI tool and the specific model used to be disclosed. Please add the actual model name to the PR description.
A CSS regression check for the 44×44 minimum touch target could also be useful, but I wouldn’t consider that blocking given the existing rendering tests and manual viewport validation.
Once the model disclosure is completed, this looks good to me.
Updated the PR description to include the specific model used: GPT-6 Astra. Thanks for the review! |
Qiyuanqiii
left a comment
There was a problem hiding this comment.
No further concerns from my side
Description
The viewer currently relies on breadcrumbs for navigation between repositories, session lists, and session details. On smaller screens, breadcrumb targets can be difficult to tap and labels may be truncated.
This change adds a visible back link beside the heading on both sub-pages:
sessions.htmllinks back to/session.htmllinks back to/r/{{.EncodedRepo}}The existing breadcrumbs remain unchanged. The new links use the existing theme variables, support light and dark modes, provide a minimum 44×44 CSS pixel touch target, and support keyboard navigation.
Implementation
internal/viewer/templates/sessions.html.internal/viewer/templates/session.html..page-headingand.back-linkstyles ininternal/viewer/static/style.css.internal/viewer/server_extra_test.go.Closes #830.
Type of Change
How Has This Been Tested?
make checkmake testmake buildgit diff --checkocr reviewcompleted with 0 findingsThe template tests cover empty and populated session lists, the detail-page back-link target, and preservation of the existing breadcrumbs.
Checklist
AI assistance: OpenAI Codex using GPT-6 Astra was used for repository inspection and implementation support. I reviewed the final diff and test results myself.