Conversation
In test_baselaplace.py and test_lllaplace.py, move sampling test code below the functional variance block. Add testing empirical covariance of weight posterior samples vs. Laplace weight posterior covariance.
Use posterior_scale.T, as discussed in
aleximmer#274
Contributor
Author
|
I can reproduce the but only the combo |
Contributor
Author
|
The lint fail is not due to changes in this PR. Also, I'm with |
elcorto
added a commit
to elcorto/laplace
that referenced
this pull request
Mar 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274
This fixes the
posterior_scale.Tissue discusssed in #274 (FullSubnetLaplace.sample()) and adds tests to make sureFullSubnetLaplace.sample()andDiagSubnetLaplace.sample()do the right thing.We also add cov sampling tests for all other Laplace variants in
tests/test_baselaplace.pyandtests/test_lllaplace.py.