Conversation
Collaborator
|
Thanks for the progress!
|
Owner
Author
|
Thanks, sounds good to me. I think |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version integrating the old asdfghjkl into Laplace directly. This allows to have it alongside the latest asdl and further integrate existing extensions, such as end-to-end differentiability and support for other loss functions. This version does not change any behavior and only integrates functions of asdfghjkl that are actually used. The only exception to this is
kernel.py, which is currently not yet used but will be worth integrating.Points to discuss:
asdfghjkl_src?asdfghjklcan be default by enabling regression?asdfghjklbecomes default, what is a sensible way to integrate it? I think we could havecurvature/asdfor the core utilities and merge the interfaces/default backends incurvature.pywithasdfghjkl.py, deprecate theAsdfghjklXYZclasses and just go withGGN, EF, Hessianfor them.