Repository navigation
history: avoid slow "builtin history" dumps in forked processes on macOS - #722
Merged
Merged
Conversation
akinomyoga
requested changes
Sep 5, 2026
akinomyoga
force-pushed
the
fix-history-dump-tz-macos
branch
from
September 5, 2026 10:14
865ef64 to
1125a91
Compare
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
akinomyoga
force-pushed
the
fix-history-dump-tz-macos
branch
from
September 5, 2026 10:14
1125a91 to
c2746d5
Compare
akinomyoga
approved these changes
Sep 5, 2026
Owner
|
Thanks. I've merged this after making adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My ~20k entry history took 4 seconds to load on macOS mostly caused by this bug and compounded by #721
This was caused due to history calling localtime for every entry when called through a fork due to Apple's libc/libnotify behavior. Setting an empty TZ fixes this
With both fixes applied history load time went from 4s to 50ms.