Repository navigation
Conversation
akiezun
marked this pull request as ready for review
September 1, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
mathlib-searchskill shared by roadmap and review workautoform-mathlib-search/v1JSONexact,partial, ormissingNon-goals
#checkDependency
Stacked on P00 (upstream facebookresearch#9), whose manifest authorizes the independent reimplementation and assigns archived Loogle behavior to this single owner. This branch is independent of P01–P03.
Validation
make lint— passedmake test— 550 passed, 1 skippedmake check-example— passed, including strict MkDocs buildTests cover local project and pinned-Mathlib search, exact/partial/missing outcomes, ambiguous suffixes, Loogle present, absent and failed fallback, deterministic JSON, read-only behavior, and rejection of invented Loogle names.
Risks and migration
The fallback is lexical name search, not type-shape search; shape queries require an installed Loogle. The helper scans local source trees and can be slower than Loogle on a full checkout, but it never installs or writes indexes.
Rollback
Revert commit
a44577d; existing Lean LSP/REPL and roadmap behavior are unchanged.