Skip to content

fixes jump-window#150

Open
agzam wants to merge 1 commit into
masterfrom
jump-window-fix
Open

fixes jump-window#150
agzam wants to merge 1 commit into
masterfrom
jump-window-fix

Conversation

@agzam

@agzam agzam commented Nov 5, 2021

Copy link
Copy Markdown
Owner

Bug discovered while testing #149. Upstream. Looks like it's broken in Hammerspoon. Removed usage of the experimental module.

#149 (comment)

@agzam agzam added bug upstream upstream bug, due to changes in dependent project(s) labels Nov 5, 2021
@jaidetree jaidetree self-requested a review November 5, 2021 06:53

@jaidetree jaidetree left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this fix a shot but doesn't seem to be working. Seems like without the filter, it's unable to find the intended target.

@Grazfather

Copy link
Copy Markdown
Collaborator

What version of Hammerspoon did you discover this on? I noticed there was an update just yesterday.

@agzam

agzam commented Nov 5, 2021

Copy link
Copy Markdown
Owner Author

I'm using Hammerspoon Version 0.9.91 (6078)
I have not upgraded OS to Monterey yet, supposedly they made some fixes for it.
I guess it broke very recently. Then let's not merge this thing just yet.
Like Sun Tzu would've said: "If you wait by the river long enough, you may see fixed bugs floating by."

@HyunggyuJang

HyunggyuJang commented Dec 12, 2021

Copy link
Copy Markdown
Contributor

I encountered the same issue, and was able to resolve with HyunggyuJang@dbb12cd

I’m not sure it is the canonical solution and works for all, so I’d like to know your opinions about it!

@agzam

agzam commented Dec 17, 2021

Copy link
Copy Markdown
Owner Author

For me - both cases work. And whatever is in the master branch - doesn't. Even though I'm now using version 0.9.93 (6148) - it's still broken. At this point, I think we have to merge a fix - using either method. However, I've noticed another thing - after jumping to the target window, Spacehammer menu doesn't go away. That looks like a regression. I'll check what's going on there.

@Grazfather

Copy link
Copy Markdown
Collaborator

I can't repro on 6172. Do you still have this issue?

@agzam

agzam commented Feb 1, 2022

Copy link
Copy Markdown
Owner Author

I can't repro on 6172. Do you still have this issue?

The latest available release is 0.9.93 (6148) - both on GitHub and via brew. How did you get 6172?

@Grazfather

Copy link
Copy Markdown
Collaborator

It was created to test a fix for an issue I reported Hammerspoon/hammerspoon#3081 https://github.com/Hammerspoon/hammerspoon/actions/runs/1726174041

@Grazfather

Copy link
Copy Markdown
Collaborator

Is this still needed?

@agzam

agzam commented May 3, 2023

Copy link
Copy Markdown
Owner Author

Is this still needed?

Yes, jump to window appears broken in master. But this "fix" doesn't seem to be fixing it for good. It works, but not reliably.

@jaawerth jaawerth mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug upstream upstream bug, due to changes in dependent project(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants