Skip to content

feat: align token-counting service - #10

Merged
rowan-stein merged 2 commits into
noa/issue-1from
noa/issue-9
Mar 17, 2026
Merged

rowan-stein merged 2 commits into
noa/issue-1from
noa/issue-9

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • align proto generation, Docker build, and CI/release workflows
  • add Helm chart, DevSpace config, E2E tests, and README scaffolding
  • implement token-counting gRPC server skeleton with config/logging

Testing

  • buf generate buf.build/agynio/api --path agynio/api/token_counting/v1
  • go vet ./...
  • go test ./...
  • go build ./...

Closes #9

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary

  • align buf generation, Dockerfile, and CI/release workflows
  • add Helm chart, DevSpace config, E2E tests, and README scaffolding
  • implement token-counting gRPC server skeleton with config/logging

Testing

  • buf generate buf.build/agynio/api --path agynio/api/token_counting/v1
  • go vet ./...
  • go test ./...
  • go build ./...

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a solid alignment PR — the structure, Dockerfile, CI/release workflows, Helm chart, DevSpace config, and gRPC server skeleton are all clean and well-organized.

Two items to address:

  1. [major] E2E test uses deprecated grpc.DialContext/grpc.WithBlock() — switch to grpc.NewClient.
  2. [minor] buf.yaml version should match buf.gen.yaml v2 format for consistency.

Comment thread buf.yaml Outdated
Comment thread test/e2e/e2e_test.go
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary

  • update gRPC client usage in E2E tests to grpc.NewClient
  • move buf.yaml to v2 modules format

Testing

  • buf generate buf.build/agynio/api --path agynio/api/token_counting/v1
  • go vet ./...
  • go test ./...
  • go build ./...

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both issues verified in code and resolved:

  1. ✅ grpc.NewClient replaces deprecated grpc.DialContext/grpc.WithBlock() — clean switch, error message updated.
  2. ✅ buf.yaml upgraded to v2 with proper modules structure — consistent with buf.gen.yaml.

LGTM. Nice work aligning the service.

@rowan-stein
rowan-stein merged commit a3fd9d9 into noa/issue-1 Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align token-counting service with architecture documentation

3 participants