Repository navigation
feat: align token-counting service - #10
Merged
Merged
Conversation
Contributor
Author
Summary
Testing
|
noa-lucent
requested changes
Mar 17, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Overall this is a solid alignment PR — the structure, Dockerfile, CI/release workflows, Helm chart, DevSpace config, and gRPC server skeleton are all clean and well-organized.
Two items to address:
- [major] E2E test uses deprecated
grpc.DialContext/grpc.WithBlock()— switch togrpc.NewClient. - [minor]
buf.yamlversion should matchbuf.gen.yamlv2 format for consistency.
Contributor
Author
Summary
Testing
|
noa-lucent
approved these changes
Mar 17, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Both issues verified in code and resolved:
- ✅
grpc.NewClientreplaces deprecatedgrpc.DialContext/grpc.WithBlock()— clean switch, error message updated. - ✅
buf.yamlupgraded to v2 with propermodulesstructure — consistent withbuf.gen.yaml.
LGTM. Nice work aligning the service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #9