Repository navigation
Conversation
Step 8 of the organization teardown: the org_nicknames the organization held. Last, because the identities those nicknames named are deleted by the services that registered them, in the steps above. The store method does not report an empty result as NotFound the way RemoveNickname does -- the step is retried, and finding nothing left is success, not a missing row. Internal RPC, so no permission check and no caller identity; the Istio policy settles that Organizations is the only caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 8 of the organization teardown: the
org_nicknamesthe organization held. Last in the order, because the identities those nicknames named are deleted by the services that registered them, in the steps above.RemoveOrganizationNicknamesdeliberately does not report an empty result asNotFoundthe wayRemoveNicknamedoes — the step is retried, and finding nothing left is success rather than a missing row.Internal RPC — no OpenFGA check and no caller identity, gated by a new Istio
AuthorizationPolicyadmitting only theorganizationsServiceAccount.Chart bumped to 0.2.0 for the new template.
Part of organization settings and deletion.