Repository navigation
Serve BatchGetNicknames to a caller with no identity - #20
Merged
Merged
Conversation
The Expose service builds an exposure address from an agent instance's handle, and its reconciler re-derives that address on a timer with no caller behind it at all. Demanding org membership of an internal service that holds no tuples makes the readable half of every agent-owned exposure unreachable. Every method here is internal-only and not exposed through the Gateway, so an identity-less caller is a platform service and is served as one -- the same treatment Agents gives GetSandbox, for the same reason. A caller that does present an identity is a user request and is checked exactly as before. Only the absence of an identity is meaningful; a malformed one is still refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks agynio/expose#36.
The Expose service builds an exposure address from an agent instance's handle, and its reconciler re-derives that address on a timer with no caller behind it at all. Demanding org membership of an internal service that holds no tuples makes the readable half of every agent-owned exposure unreachable — it would silently fall back to the opaque address forever.
Every method here is internal-only and not exposed through the Gateway, so an identity-less caller is a platform service and is served as one — the same treatment
AgentsgivesGetSandbox, for the same reason. A caller that does present an identity is a user request and is checked exactly as before.Only the absence of an identity is meaningful; a malformed one is still refused.
The test asserting the old behaviour (
missing header → Unauthenticated) is replaced by one asserting the new, with an authorization client that denies everything — consulting it at all would be the bug.