Repository navigation
Pick a private resource as an egress rule destination - #151
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create-rule dialog gains a destination choice: a public domain, or one of the organization's private resources — only
http/httpsresources are offered, atcpstream having nothing a rule can act on. A private destination hides the ports field (the rule covers every intercept port the resource declares) and, for anhttpsresource, offers the upstream TLS settings (server name, CA bundle secret, skip verification). The destination is fixed for the rule's life, so both selectors are read-only in edit mode; the create dialog states that a resource's first rule moves its traffic onto the egress gateway, and the delete confirmation states the flip back.The rules list shows the destination as the resource's name and intercept host, and the private resource detail page's access list now answers "who can reach this?" completely: principals reaching the resource through an attached rule appear beside the direct grants, labelled with their source, with revocation pointed at the rule.
Part of egress rules address private resources; protocol change in agynio/api#193.