Skip to content

Delete a conversation from the actions menu - #115

Merged
vitramir merged 1 commit into
mainfrom
feat/delete-chat
Aug 13, 2026
Merged

vitramir merged 1 commit into
mainfrom
feat/delete-chat

Conversation

@vitramir

Copy link
Copy Markdown
Contributor

Adds Delete conversation to the conversation actions menu, behind a confirmation dialog that names the conversation and states that it disappears for everyone in it. The row leaves the cached list immediately and returns if the call fails; deleting clears the draft, the selection, and the route.

A link to a deleted conversation now falls back to the empty state instead of rendering a placeholder header over a transcript the app no longer lists.

Also fixes test isolation: without vitest globals, testing-library never unmounted between tests, so a second render in a file leaked the first one's DOM.

Needs agynio/api#189 (merged), agynio/chat#36, agynio/gateway#208.
Spec: changes/2026-08-13-chat-deletion.md

The conversation actions menu gains Delete conversation, behind a
confirmation that names the conversation and states that it disappears for
everyone in it. Deleting clears the draft, drops the selection, and returns
to the list; the row leaves the cached pages immediately and comes back if
the call fails.

A link to a deleted conversation used to render a placeholder header over a
transcript the app no longer lists. Chat now answers NOT_FOUND for it, and
that is the signal to drop the selection and fall back to the list.

Rendering two components in one test file leaked the first into the second,
because without vitest globals testing-library never unmounts between tests.
The setup file now cleans up.

See agynio/architecture: changes/2026-08-13-chat-deletion.md
@vitramir
vitramir requested a review from a team as a code owner August 13, 2026 16:54
@vitramir
vitramir merged commit 1547dcd into main Aug 13, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant