Repository navigation
feat(nav): take sibling product addresses from configuration - #113
Merged
Merged
Conversation
The product switcher built its links by replacing the first label of the current hostname with the sibling's name, which holds only while every app is served at <product>.<domain>. An install at chat-agyn.example derived console.example -- a host that exists nowhere on it -- so every entry led to a 404, along with the tracing link and the agent settings link out to the console. MEDIA_PROXY_URL moves to the same mechanism. It stays out of the chart's env: block with the other four, because an explicit empty variable shadows extraEnvVarsCM, which is how the umbrella feeds them -- so leaving it there would have kept the media proxy guessing while the rest were told. mediaProxyUrl goes with it; bundle-vm was its only caller and now sets platform.externalUrls.mediaProxy. Read CHAT_URL, TRACING_URL, CONSOLE_URL and SANDBOXES_URL, and derive only where one is unset, so default installs and devspace are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The product switcher built its links by replacing the first label of the current hostname with the sibling's name, which holds only while every app is served at
<product>.<domain>. An install atchat-agyn.examplederivedconsole.example— a host that exists nowhere on it — so every entry led to a 404, along with the tracing link and the agent settings link out to the console.The image offered no way to correct it:
__config.jscarriedAPI_BASE_URL,MEDIA_PROXY_URLand the OIDC settings and nothing else.Now reads
CHAT_URL,TRACING_URL,CONSOLE_URLandSANDBOXES_URL, deriving only where one is unset, so default installs and devspace are untouched. The umbrella feeds them throughenvFromfrom a ConfigMap it derives from the routes it already declares.Breaking, chart only.
MEDIA_PROXY_URLleaves the chart'senv:block and themediaProxyUrlvalue goes with it. An explicit empty variable shadowsextraEnvVarsCM, so leaving it there would have kept the media proxy guessing while the other four were told. bundle-vm was the only caller and now setsplatform.externalUrls.mediaProxy; anyone else settingmediaProxyUrlshould move toextraEnvVarsor the umbrella value.Same change as agynio/console-app#143, which carries the tests for the shared logic.